Don't retransmit a PipeDuplexRequestBody #2791
Merged
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carranca
approved these changes
Jan 20, 2024
| // Give the mock server invalid actions (SendCompleted with no response message), which will | ||
| // cause it to reset the socket connection. | ||
| mockService.enqueue(ReceiveCall("/routeguide.RouteGuide/RecordRoute")) | ||
| mockService.enqueue(SendCompleted) |
There was a problem hiding this comment.
A-ha, nice and cleaner than the initial attempts.
| // Confirm we get an IOException from the broken connection and not an IllegalStateException | ||
| // from incorrectly attempting to recover. | ||
| val (requestChannel, deferredResponse) = routeGuideService.RecordRoute().executeBlocking() | ||
| val e = assertFailsWith<IOException> { |
There was a problem hiding this comment.
Did you confirm that without your fix this was producing IllegalStateException?
oldergod
approved these changes
Jan 22, 2024
| @@ -39,4 +39,7 @@ internal class PipeDuplexRequestBody( | |||
| } | |||
|
|
|||
| override fun isDuplex() = true | |||
|
|
|||
| /** [Pipe.fold] can only be called once. */ | |||
| override fun isOneShot() = true | |||
Closed
|
When is this change shipping to a new version? @oldergod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.