Fix RealGrpcCall timeout #2816
Merged
Fix RealGrpcCall timeout #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGulbronson
force-pushed
the
jgulbronson.fix-RealGrpcCall-timeout
branch
from
72c462b
to
62e9398
Compare
swankjesse
reviewed
Feb 1, 2024
| @@ -85,6 +86,9 @@ class GrpcClientTest { | |||
| private lateinit var incompatibleRouteGuideService: IncompatibleRouteGuideClient | |||
| private var callReference = AtomicReference<Call>() | |||
|
|
|||
| // Just set to a large enough value we won't timeout in tests | |||
| private val okHttpClientTimeout = Duration.ofSeconds(117) | |||
swankjesse
approved these changes
Feb 1, 2024
oldergod
approved these changes
Feb 2, 2024
| @@ -85,6 +86,9 @@ class GrpcClientTest { | |||
| private lateinit var incompatibleRouteGuideService: IncompatibleRouteGuideClient | |||
| private var callReference = AtomicReference<Call>() | |||
|
|
|||
| // Just set to a large enough value we won't timeout in tests | |||
| private val okHttpClientTimeout = Duration.ofSeconds(117) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LateInitTimeoutdoesn't actually work properly, and overwrites the new with the old, instead of the old with the new. I'm not convinced it's needed, and since it's internal to Wire, I'm hoping I can just delete it and useForwardingTimeoutinstead.Added a test to verify that the timeout is preserved after
initCallis called.