-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on annotations.proto #2927
Comments
As the error specifies, you cannot define extensions in proto3 files. Change the syntax or don't use an extension? |
Ok thanks for your reply! Why is it that other libraries like KrotoDC or even the protoc-gen/protobuf libraries for Java/Kotlin are able to process this file without crashing? Is the Wire Compiler more strict? Also, what would be an alternate syntax that I could use? |
Thank you. It looks like we missed that when adding proto3 support. Extensions are allowed for defining options, even in proto3 files. I can fix that at some point but your best move right now would be to move this extension definition in a proto2 file. |
Actually @santhanamk you can get your build pass by removing the leading - extend .google.protobuf.MethodOptions {
+ extend google.protobuf.MethodOptions { |
@oldergod if I remove the I think it is due to the For proto3 however, after I remove the If I downgrade to proto2 and move that Do you know by roughly when you could fix this bug? Thanks for your help. |
Any syntax error in the |
The fix, I would not count on it before the summer. Might happen before. |
ok thank you! |
I have this annotations.proto file:
But when it gets processed by the Wire Gradle plugin (via Android Studio) I get this crash:
Cause: extensions are not allowed in proto3
for extend google.protobuf.MethodOptions (...app/src/main/proto/google/annotations.proto:28:1)
Is there a workaround or solution for this?
The text was updated successfully, but these errors were encountered: