Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentDialog.asDialogHolderWithContent should provide decor view as container #1097

Open
rjrjr opened this issue Aug 3, 2023 · 0 comments

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Aug 3, 2023

This:

    .buildView(overlay.content, envWithOnBack, context)

should be this:

    .buildView(overlay.content, envWithOnBack, context, decorView as ViewGroup)

But watch out for the perils of resolving decorView too early I hate Android. (Note use of our Dialog.decorView extension.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant