Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write database-backed example for kotlin #769

Open
rjrjr opened this issue Sep 12, 2019 · 9 comments · May be fixed by #1099
Open

Write database-backed example for kotlin #769

rjrjr opened this issue Sep 12, 2019 · 9 comments · May be fixed by #1099
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed kotlin points: 1

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Sep 12, 2019

We need example of driving long, random access list from a database —  RecyclerView pulling from Rooms or SqlDelight

@zach-klippenstein
Copy link
Collaborator

And/or the AndroidX paging library

@zach-klippenstein zach-klippenstein added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed points: 1 labels Oct 4, 2019
@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
@RotBolt
Copy link
Contributor

RotBolt commented Feb 16, 2023

@rjrjr Is this still a valid issue? If yes, I would like to work upon it

@rjrjr
Copy link
Contributor Author

rjrjr commented Feb 16, 2023

Yes please! It would need to be a separate module so that none of the existing ones get tied to whatever SqlDelight or whatever. At this point a Compose example might be more useful than RecyclerView or AndroidX Paging.

@rjrjr
Copy link
Contributor Author

rjrjr commented Feb 16, 2023

@steve-the-edwards or @RBusarow would probably be a better reviewer / co-designer for it than I would.

@RotBolt
Copy link
Contributor

RotBolt commented Feb 28, 2023

Sure, I will get started with jetpack compose only. @steve-the-edwards @RBusarow let me know if there is anything I need to know apart from the workflow-kotlin docs

@rjrjr
Copy link
Contributor Author

rjrjr commented Mar 1, 2023

🍿

It'd be wise to share a quick description of whatever design you're thinking of as a sanity check.

@RotBolt
Copy link
Contributor

RotBolt commented Mar 1, 2023

Sure. I will share by weekend

@RotBolt
Copy link
Contributor

RotBolt commented Mar 21, 2023

Hi @rjrjr
Sorry for too much delay from side
I am thinking of extending the Todo example which is in Tutorial section.
For the UI part, in LayoutRunners, where we are setting the data in adapters currently. I believe I can simply render the list with Jetpack compose.
For database, currently thinking of using Room library only for Worker implementation. I will have the Worker as a dependency inside TodoListWorkFlow sth like TodoListWorkFlow(val worker:TodoWorker).

Rest of the details, I believe I would be able to tell when I actually get to start write an example

@RotBolt
Copy link
Contributor

RotBolt commented Jun 15, 2023

I am sorry, I was MIA for 3 months or so, there was a family emergency
I have started tutorials as of now. I will get to create database backed example soon

@RotBolt RotBolt linked a pull request Aug 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed kotlin points: 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants