Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose's insets are lost through a backstack container #855

Open
Kernald opened this issue Aug 3, 2022 · 3 comments
Open

Compose's insets are lost through a backstack container #855

Kernald opened this issue Aug 3, 2022 · 3 comments

Comments

@Kernald
Copy link
Contributor

Kernald commented Aug 3, 2022

When using a certain configuration of nested workflows (I haven't found exactly the logic there), involving a backstack container (it might be a red herring I guess), Compose's insets are not propagated.

There's a repro here.

In MainActivity.kt/HelloComposeModel, the first workflow that's started is NavigationWorkflow, which in turns starts BackStackWorkflow either with or without a backstack - the insets are missing if there's a backstack. However, if HelloComposeModel starts NavigationWorkflow directly, regardless of with or without a backstack, everything works just fine.

This started appearing after an upgrade to Compose 1.2.0, insets were previously part of Accompanist and went through quite a bit of a change (https://google.github.io/accompanist/insets/#migration-table).

@steve-the-edwards
Copy link
Contributor

cc @rjrjr I remember seeing something related to this in your UI work recently?

@zach-klippenstein
Copy link
Collaborator

I wonder if this has something to do with view/compose interop?

@Kernald
Copy link
Contributor Author

Kernald commented Oct 24, 2022

I'm not 100% done with my migration just yet but it seems this might be fixed with Compose 1.3.0. I'll try updating my repro repo linked above to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants