New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid diagrams rendering to dark in dark mode (8.3.0 regression) #4000
Comments
Thanks for reporting and congratulations on issue #4000! This is very likely a regression that got introduced due to the drop in specificity on the dark mode selectors. I'll look into it asap. |
Fixed in 26010be. |
The fix was released as part of 8.3.3. |
Again, a fantastic response time! Thanks! |
I'm not sure if this regressed again or if titles specifically were overlooked. It might warrant its own ticket, but I notice that titles still have the default styling when in dark mode, making them difficult to read |
If Mermaid.js changes something upstream, we might need to adapt. Regardless, we're going to need a new issue with a minimal reproduction to investigate. Please also carefully study our bug reporting process. |
Contribution guidelines
I've found a bug and checked that ...
mkdocs
orreadthedocs
themescustom_dir
,extra_javascript
andextra_css
Description
When upgrading form 8.2.16 to 8.3.2, I noticed that the Mermaid diagrams fonts and colors are not following the theme fonts and colors as before.
With 8.2.16:
With 8.3.2:
Expected behaviour
The 8.2 behavior is expected.
Actual behaviour
The fonts and colors of diagrams are not consistent with the theme.
Steps to reproduce
Package versions
3.10.4
1.3.0
8.3.2
Configuration
System information
The text was updated successfully, but these errors were encountered: