Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content tabs: Buttons do not have an accessible name #4977

Closed
4 tasks done
m4g3s opened this issue Feb 2, 2023 · 2 comments
Closed
4 tasks done

Content tabs: Buttons do not have an accessible name #4977

m4g3s opened this issue Feb 2, 2023 · 2 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@m4g3s
Copy link

m4g3s commented Feb 2, 2023

Context

No response

Bug description

Content tab buttons do not have an accessible name

I found this error via Lighthouse.

Related links

Reproduction

example.zip

Steps to reproduce

  1. create a content tab on any page
  2. run Lighthouse
  3. it will report that the buttons won't an accessible name

Browser

Chrome

Before submitting

@m4g3s m4g3s added the needs investigation Issue must be investigated by the maintainers label Feb 2, 2023
@squidfunk
Copy link
Owner

Thanks for reporting! So those are the buttons that appear on the overflow of the tab label container. Since those are not keyboard-focusable anyway, I've added the missing aria-hidden attribute to both of them. Fixed in c330a08.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Feb 2, 2023
@squidfunk
Copy link
Owner

Released as part of 9.0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants