Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border displayed around expand button during animation on Firefox #5072

Closed
4 tasks done
wilhelmer opened this issue Feb 20, 2023 · 4 comments
Closed
4 tasks done

Border displayed around expand button during animation on Firefox #5072

wilhelmer opened this issue Feb 20, 2023 · 4 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@wilhelmer
Copy link
Contributor

Context

No response

Bug description

On Firefox, a small border is displayed around the "expand" button during its animation:

expand-button-firefox.mov


This does not happen on Chrome:

expand-button-chrome.mov

Related links

None

Reproduction

example.zip

Steps to reproduce

  1. Build the sample project.
  2. Click on the expand button next to "Section".

Browser

Firefox

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. Possibly related: https://bugzilla.mozilla.org/show_bug.cgi?id=1671784

@squidfunk squidfunk added the bug Issue reports a bug label Feb 20, 2023
@squidfunk
Copy link
Owner

Thanks for reporting! While it is not completely fixable, I think I found a good solution in 1663d84. The rotation is now defined on the icon (pseudo element), not the containing element, and by setting border-radius to the same value as the containing element the issue is almost entirely gone. Here's a video with a bright color which makes it particularly apparent:

Ohne.Titel.mp4

Note that the video itself has compression artifacts 😅 Let's hope that this get fixed in Firefox soon.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Feb 22, 2023
@wilhelmer
Copy link
Contributor Author

wilhelmer commented Feb 22, 2023

The bug is 2 years old, so I wouldn't count on it 😜 But it's therefore even better that you fixed it (or rather worked around it), worth the effort. Thanks!

@squidfunk
Copy link
Owner

Released as part of 9.0.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants