Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in search plugin doesn't properly filter script and style tags #5198

Closed
4 tasks done
veghdev opened this issue Mar 14, 2023 · 4 comments
Closed
4 tasks done

Built-in search plugin doesn't properly filter script and style tags #5198

veghdev opened this issue Mar 14, 2023 · 4 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@veghdev
Copy link

veghdev commented Mar 14, 2023

Context

Based on this

mkdocs-jupyter integrates notebooks into mkdocs site. Its output, style etc are included in the search index, so the index file will be very large.

Bug description

"The cause seems to be that subsequent script/style/object tags are not skipped correctly due to mutations on the list of elements to be skipped. I'll issue a bugfix release when I get some time to work on it. Regardless, it's bad practice to include so many inline styles and scripts repeatedly in the page content – those inline scripts and styles should be moved to external resources." by @squidfunk

Related links

Reproduction

file:///home/david/Downloads/mkdocs-jupyter-search-main.zip
file:///home/david/Downloads/dump.html.zip

Steps to reproduce

make
make doc

Browser

Chrome

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting.

file:///home/david/Downloads/mkdocs-jupyter-search-main.zip
file:///home/david/Downloads/dump.html.zip

I'm having a hard time accessing your local files 😅

@squidfunk squidfunk added the bug Issue reports a bug label Mar 14, 2023
@squidfunk squidfunk changed the title Built-in search plugin script/style/object tags are not skipped correctly due to mutations on the list of elements to be skipped Built-in search plugin doesn't properly filter script and style tags Mar 14, 2023
@veghdev
Copy link
Author

veghdev commented Mar 14, 2023

@squidfunk
Copy link
Owner

Thanks! Fixed in 2c7b0a3.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Mar 14, 2023
@squidfunk
Copy link
Owner

Released as part of 9.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants