New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to the dark theme of modern browsers corresponding to the scroll bar under the dark theme #5566
Comments
Thanks for suggesting! Fixed in fe0c966. We opted for the CSS As an addendum, here's a good read on |
Your document website looks the same as it did before the fix commit |
I have some other suggestions. I think the background color in dark mode should be more towards black. Preferably controlled by the user via css variables. The problem now is that when the background color or theme color is changed, the background color of some button hover does not change accordingly. This often requires providing multiple tones of different depths at the same time. So my suggestion has two solutions: one is that the user only defines one main color, and the auxiliary colors of other depths are automatically provided by dependencies, such as tinycolor of npm; the other is to define a whole set of variables in css instead. Docusaurus provides an online solution styling-your-site-with-infima |
The changes haven't been merged in Insiders yet, and our site is built with Insiders. We'll do that before the next release.
Please create a discussion for your suggestion with some screenshots or a screencast, so we can better understand what you want to see |
Released as part of 9.1.15! |
Are you sure it works? I think this should be provided by default rather than user-defined. |
Yes, mkdocs-material/src/assets/stylesheets/palette/_scheme.scss Lines 30 to 34 in fe0c966
|
no effect |
Works perfectly for me. If I visit our documentation site, and add an unstyled input field to the content, it will adapt to the OS color scheme: If I uncheck |
Your screenshot doesn't show scrollbars. I raise this question mainly to solve the display problem of the browser's default scrollbar under the dark theme. After my tests, this may need to be defined on the head tag. Because I have tried to do this with css before raising this issue |
Okay, so we might need to set the |
Fixed in d2f4034. The |
It's worked |
Released as part of 9.1.16. |
Context
add head meta
Description
The scroll bar can use the dark mode. If the scroll bar still displays the default light mode after switching to the dark mode it will be uncomfortable
Related links
Use Cases
Docusaurus2 Vuepress
Visuals
No response
Before submitting
The text was updated successfully, but these errors were encountered: