Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: enabling use_directory_urls: false breaks pagination #5899

Closed
4 tasks done
vedranmiletic opened this issue Aug 26, 2023 · 3 comments
Closed
4 tasks done

Blog: enabling use_directory_urls: false breaks pagination #5899

vedranmiletic opened this issue Aug 26, 2023 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@vedranmiletic
Copy link
Contributor

Context

No response

Bug description

Trying to build the minimal example with two post and pagination set to one post per page fails with:

ERROR   -  Error building page 'blog/index.md': [Errno 20] Not a directory: '/tmp/mkdocs_mktockyk/blog/index.html/page'

This is a regression compared to version 9.2.0b3, where it works correctly.

Related links

Reproduction

9.2.4-use_directory_urls-false-breaks-pagination.zip

Steps to reproduce

  1. run mkdocs build
  2. observe the ERROR in console

Browser

No response

Before submitting

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Aug 26, 2023
@squidfunk
Copy link
Owner

Thanks for reporting! Fixed in fbb7a5e. Additionally, I realized that the blog post title Latest posts was not correctly carried over to paginated views. This was fixed in the same commit.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Aug 27, 2023
@squidfunk squidfunk changed the title Enabling use_directory_urls: false breaks Blog index pagination (regression since 9.2.0b3) Blog: enabling use_directory_urls: false breaks pagination Aug 27, 2023
@squidfunk
Copy link
Owner

Okay, one more fix was necessary in 568a5c8 in order to preserve titles that are set from Markdown pages.

@squidfunk
Copy link
Owner

Released as part of 9.2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants