New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using blog and tags plugins in combination results in wrong links to Blog index #5952
Comments
Fixed in 84cb91b. I think I found all cases and refactored how paginated views are handled during rendering with a more resilient approach. The problem reported was not exclusive to the tags plugin, but also happened when you went to the second page of the archive, and then clicked on "Latest posts", also ending up on the last page. |
This commit actually causes a regression, which in my case manifests as |
9.2.7-url-not-in-list-regression.zip Note that I am not really using version 9.2.7 here, but the git master (and I have independently bisected the bad commit to 84cb91b). The error I get is:
|
Thanks, looking into it. |
Fixed in 682d176. Thanks again for testing and providing the minimal reproduction – it only happened with 3 pages or more. I've tested the head of master against all reproductions we received related to the blog and think that it's finally stable... until the next bug appears 😅 If you can confirm that it works for you, we can release it today with the other fixes. |
Unfortunately not, the original bug seems to be back, both on the test case and real-world sites. I made sure several times that I am using the right version. Can you check on your side? |
Yes, the bug is back. I only checked the links in the navigation and they were all correct. I'll take a look. This is so exceptionally tricky to get right in all possible constellations... |
... and the next attempt in fc566cf. The links should now all be correct, unless I'm missing something. I've also, again, made sure this didn't break URLs for previously fixed issues. |
@vedranmiletic when you find some time, it would be great if you could verify if your issue is now fixed. We're waiting with the next release until this issue is fixed, so it would be awesome if you could check if the problem is gone |
Sure, go ahead. The issue looks fixed to me now. Thanks! There is another small unrelated issue with |
Thanks! Released as part of 9.2.8. |
hello @squidfunk I get this just by including the full trace:
|
@squidfunk nevermind the rushed questions.. I fixed it by including |
Context
No response
Bug description
When
blog
andtags
plugins are enabled together, the links to Blog index will be rendered as linking to the last page of the index instead of the first page.Related links
Reproduction
9.2.7-using-blog-and-tags-in-combination.zip
Steps to reproduce
mkdocs serve
tags
plugin configuration fromplugins
section inmkdocs.yml
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: