Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor avatar displays in square shape until hovered over #6001

Closed
2 tasks done
Andre601 opened this issue Sep 14, 2023 · 6 comments
Closed
2 tasks done

Contributor avatar displays in square shape until hovered over #6001

Andre601 opened this issue Sep 14, 2023 · 6 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@Andre601
Copy link
Contributor

Description

The avatars of the page contributors display in a square shape at the bottom of the page. When you then hover over them do they change their shape to a circle, without any transition.

Avatar displayed:
grafik

Avatar when hovered over:
grafik

Related links

Proposed change

No response

Before submitting

@Andre601 Andre601 added the documentation Issue concerns the documentation label Sep 14, 2023
@Prakhar301101
Copy link

Do you want the avatars to be displayed in a square shape and on hover change their shape to circle with transition?
As of now they are displayed in a circle and when I hover over it just changes color and gets grows a little

@squidfunk
Copy link
Owner

squidfunk commented Sep 14, 2023

Thanks for reporting. However, this should not be a documentation issue but a bug report. There's essential information missing, including in which browser this is happening. It's not happening in my browser, so you seem to be using another browser that exhibits this behavior. Additionally, what should happen from your point of view? You did not even go through the trouble of proposing a change or describing your expectations. We kindly ask you to create a proper issue with a minimal reproduction, and please stop misusing the issue templates. Choose the right template for the thing you want to report.

Closing as incomplete.

@Andre601
Copy link
Contributor Author

I chose this template for particular reasons:

First of all is this something I encountered within your documentation. Additionally did this visual inconsistency not exist a few months ago and may be a bug introduced within more recent releases (or from a browser update more recently).

Next, and most importantly, do I not have access to insiders and therefore no access to the contributors plugin that comes with it.
So making a minimal reproduction here would be a waste of both our time here for no benefit. Especially if the info such as browser type and version could also be provided here too (Firefox 117.1.0 for android btw. Also happens desktop version).

@vedranmiletic
Copy link
Contributor

@squidfunk I can confirm this issue in Firefox, but I always assumed it is the intended behavior. Now that I have checked in Brave I see it is not. The correct description of the issue would be something along the lines

Contributor avatars are incorrectly displayed as squares instead of circles in Firefox (the issue doesn't affect avatar display when hovered, where avatars are correctly displayed as circles)

@squidfunk
Copy link
Owner

Thanks @vedranmiletic – should be fixed in d322e49. It seems to be a recent bug in Firefox where setting border-radius without border on an image does not apply the rounding. Hoisting the property one level gets rid of the issue:

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed documentation Issue concerns the documentation labels Sep 19, 2023
@squidfunk
Copy link
Owner

Released as part of 9.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

4 participants