Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer overlaps with vertical navigation sections on small screens #6118

Closed
4 tasks done
odysseu opened this issue Oct 2, 2023 · 4 comments
Closed
4 tasks done

Footer overlaps with vertical navigation sections on small screens #6118

odysseu opened this issue Oct 2, 2023 · 4 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@odysseu
Copy link

odysseu commented Oct 2, 2023

Context

I saw this bug on a gitlab-pages I built with your (great) tool; and actually could reproduce it to your site 馃ゲ

Bug description

Hi, similar to the issue regarding blog and footer overlap (#6094),

comment screenshot
the vertical navigation sections on the left-side of the site overlaps with the footer. image

Related links

Reproduction

no need for zip as it appears on the official site

Steps to reproduce

0 - got to official doc
1 - Reduce the browser's viewport width to less than 1220px
2 - Scroll to the footer section

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting. Please, please, please respect our work and time and always stick to our bug reporting process, which clearly states that we need a reproduction. We're helping our users for free and this mandates that you always stick to what is asked for. Why? Because I have no idea under what circumstance this problem occurs without more data:

screenshot-squidfunk-github-io-mkdocs-material-reference-1696238771481

To be clear, below 1220px the sidebar is hidden, so we have no idea why this is triggered. We're missing important information, i.e., browser, zoom level, etc. Closing as not reproducible.

@squidfunk squidfunk added the needs reproduction Issue lacks a minimal reproduction .zip file label Oct 2, 2023
@odysseu
Copy link
Author

odysseu commented Oct 3, 2023

Right, apologies for the missing reproducibility.

More context:

  • firefox 115.2.1esr (64 bits)
  • zoom at which it is not ok : 120 % and 133% only.
  • screen size is 1366 x 768 pixels
screenshot 120% screenshot 133%
image image

Here is the .zip of the site: mkdocs-material-9.4.3.zip

@squidfunk
Copy link
Owner

squidfunk commented Oct 3, 2023

Erm, zipping our entire site is not a reproduction... I really feel like I'm wasting my time. Anyway, I can see the issue now. Read here why this is currently not fixable: #5530

@squidfunk
Copy link
Owner

squidfunk commented Oct 3, 2023

Okay, so regardless of the fact that I'm not happy when users don't follow our bug reporting guidelines, as it necessitates more of our time that we could otherwise invest into actually fixing bugs and creating new useful features, I just had an idea: why not try subpixel values to bring the min- and max-width breakpoints together? I've tested at various zoom levels and it seems to do the trick. Thus, potential fix in 442bd1b.

Addendum: it's already deployed on our site.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs reproduction Issue lacks a minimal reproduction .zip file labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants