Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page hide property for tags not working after update #6157

Closed
4 tasks done
gioacchinopoletto opened this issue Oct 8, 2023 · 5 comments
Closed
4 tasks done

Page hide property for tags not working after update #6157

gioacchinopoletto opened this issue Oct 8, 2023 · 5 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@gioacchinopoletto
Copy link

gioacchinopoletto commented Oct 8, 2023

Context

No response

Bug description

After upgrading to 9.4.4 (prior using 9.4.2) the hide property on a page not working, and tags start appearing on page top.
Rollback to 9.4.2 all work fine.

Related links

Reproduction

Archivio.zip

Steps to reproduce

  1. Add tags on plugin section of mkdocs.yml
  2. Add hide property for tags as described on documentation
  3. Upgrade to 9.4.4
  4. See that tags still appear on top of page (not occur prior updating from 9.4.2)

Browser

Chrome, Safari, Firefox

Before submitting

@squidfunk
Copy link
Owner

squidfunk commented Oct 9, 2023

Thanks for reporting. However, this is not a minimal reproduction – the mkdocs.yml alone contains 160 lines and there are 30-40 pages. Please create a minimal reproduction, and we're happy to look into it.

Also please make sure to use the info plugin (mandatory).

@squidfunk squidfunk added the needs reproduction Issue lacks a minimal reproduction .zip file label Oct 9, 2023
@gioacchinopoletto
Copy link
Author

Thanks for reporting. However, this is not a minimal reproduction – the mkdocs.yml alone contains 160 lines and there are 30-40 pages. Please create a minimal reproduction, and we're happy to look into it.

Also please make sure to use the info plugin (mandatory).

I have try to generate a minimal reproduction with info plugin but I receive these errors on console:

gpoletto@Yoda mkdocs-minimal % mkdocs build
INFO    -  Started archive creation for bug report

Please name your bug report (2-4 words): 01
Traceback (most recent call last):                     
  File "/usr/local/bin/mkdocs", line 8, in <module>                                     
    sys.exit(cli())                                            
             ^^^^^                                                  
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1157, in __call__                                                 
    return self.main(*args, **kwargs)    
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                  
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1078, in main        
    rv = self.invoke(ctx)   
         ^^^^^^^^^^^^^^^^                                                                       
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)                                    
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                       
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)                                            
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/mkdocs/__main__.py", line 286, in build_command
    build.build(cfg, dirty=not clean)                                                                   
  File "/usr/local/lib/python3.11/site-packages/mkdocs/commands/build.py", line 277, in build
    config = config.plugins.on_config(config)                                                 
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                       
  File "/usr/local/lib/python3.11/site-packages/mkdocs/plugins.py", line 527, in on_config
    return self.run_event('config', config)                                                      
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                        
  File "/usr/local/lib/python3.11/site-packages/mkdocs/plugins.py", line 507, in run_event
    result = method(item, **kwargs)                                                             
             ^^^^^^^^^^^^^^^^^^^^^^                                                            
  File "/usr/local/lib/python3.11/site-packages/material/plugins/info/plugin.py", line 130, in on_config
    "\n".join(sorted([                                                                       
                     ^                           
  File "/usr/local/lib/python3.11/site-packages/material/plugins/info/plugin.py", line 131, in <listcomp>
    "==".join([package.name, package.version])                                            
TypeError: sequence item 0: expected str instance, NoneType found                                                                    
gpoletto@Yoda mkdocs-minimal % 

@gioacchinopoletto
Copy link
Author

I will attach the minimal package created that have same error (2 pages: index, tags) and config file.
mkdocs-minimal.zip

@squidfunk
Copy link
Owner

Thanks for providing the minimal reproduction and for checking which version worked last, that made fixing this problem very straight-forward! We refactored tags layout in 9.4.3, which caused this problem. Fixed in 53749f2.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs reproduction Issue lacks a minimal reproduction .zip file labels Oct 10, 2023
@squidfunk
Copy link
Owner

Released as part of 9.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants