Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post metadata is slightly vertically scrollable on small screens #6169

Closed
4 tasks done
sisp opened this issue Oct 10, 2023 · 5 comments
Closed
4 tasks done

Blog post metadata is slightly vertically scrollable on small screens #6169

sisp opened this issue Oct 10, 2023 · 5 comments
Labels
bug Issue reports a bug 🏆 perfect Issue is of outstanding quality resolved Issue is resolved, yet unreleased if open

Comments

@sisp
Copy link
Contributor

sisp commented Oct 10, 2023

Context

No response

Bug description

Blog post metadata on small screens (less than 1220px width) can be slightly scrolled along the y-axis although there's enough space to show the complete metadata without scrolling. Scrolling makes sense on large screens (1220px width or more) when the metadata is placed in the sidebar and the screen height is insufficient to show the complete metadata, but scrolling should be disabled on small screens.

image

Related links

Reproduction

9.4.5-blog-metadata-scroll-small-screen.zip

Steps to reproduce

  1. Start the reproduction site.
  2. Go to http://localhost:8000/blog/2023/01/31/lege-est-in-sit-est/.
  3. Reduce the browser's viewport width to less than 1220px.
  4. Scroll to the blog post metadata section above the footer.
  5. Hover the blog post metadata with the mouse, observe the visible vertical scrollbar only for the metadata container, scroll via mouse wheel and observe some slight scrolling only within the metadata block.

Browser

No response

Before submitting

@alexvoss
Copy link
Sponsor Collaborator

Thanks for the reproduction. I can confirm this for Firefox, Safari and Chrome. The scrollbars seem to be implemented deliberately, I assume with good reason. The question, then, is probably only one of making it less likely that they appear. Perhaps there is a tweak that @squidfunk can apply.

In the meantime, the overflow-y property is set to auto on a div with the class .md-sidebar__scrollwrap. If you are sure that this will not cause problems for your site you could override this in extra.css:

.md-sidebar__scrollwrap {
  overflow-y: visible
}

Hope this helps.

@squidfunk squidfunk added the bug Issue reports a bug label Oct 11, 2023
@squidfunk
Copy link
Owner

Thanks for reporting! Indeed, the sidebar which hosts the blog post information has several shortcomings that need to be addressed, which we will do when working on the blog templates again. For now, 2800e7e should be a bandaid.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Oct 14, 2023
@squidfunk
Copy link
Owner

Oh, and thanks for all of the great bug reports and reproductions that you're submitting lately, @sisp. Really good work that helps us to identify the root causes of the reported problems quickly to fix them.

@squidfunk squidfunk added the 🏆 perfect Issue is of outstanding quality label Oct 14, 2023
@sisp
Copy link
Contributor Author

sisp commented Oct 14, 2023

Thanks for fixing this problem so promptly. 🙏

I'm glad to help, at the very least through helpful reports. 🙂 Thanks for your fantastic work on this project! 🎉

@squidfunk
Copy link
Owner

Released as part of 9.4.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug 🏆 perfect Issue is of outstanding quality resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

3 participants