Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in right nav styles on safari v17.1 #6281

Closed
4 tasks done
tlambert03 opened this issue Nov 2, 2023 · 3 comments
Closed
4 tasks done

Bug in right nav styles on safari v17.1 #6281

tlambert03 opened this issue Nov 2, 2023 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@tlambert03
Copy link

tlambert03 commented Nov 2, 2023

Context

No response

Bug description

commit 521f727 seems to have introduced a bug wherein the right nav appears clipped in safari (Version 17.1 (19616.2.9.11.7)) after page refresh. resizing the window across any breakpoint fixes it)

Untitled.mov

The issue is visible as of v9.4.2 and git bisect put the issue at 521f727

chrome, Firefox, edge work fine.

Related links

I was unable to find any other related issues since sept 23, which is when 521f727 was merged

Reproduction

9.4.7-right-nav.zip

(edited to a more minimal lockfile)

Steps to reproduce

This bug can be seen on a brand new install. with only the theme added mkdocs.yml

mkdir test
cd test
pip install --upgrade --force-reinstall mkdocs-material
mkdocs new .
echo "\ntheme:\n  name: material" >> mkdocs.yml
mkdocs serve

In safari v17.1 the right nav is missing until you resize the window (see example above).

pip install 'mkdocs-material<9.4.2'
mkdocs serve

fixed...

pip install 'mkdocs-material==9.4.2'
mkdocs serve

broken

Browser

Safari

Before submitting

@squidfunk squidfunk added the needs investigation Issue must be investigated by the maintainers label Nov 5, 2023
@squidfunk
Copy link
Owner

Thanks for reporting. This issue is related to #3396 and has coincidentally been fixed in #6351 solving #6344 by the awesome @alexvoss. If I revert the fix, I can observe what is described in OP, but the latest master doesn't exhibit this behavior. Thus, we can conclude that this issue is resolved.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open and removed needs investigation Issue must be investigated by the maintainers labels Nov 19, 2023
@squidfunk
Copy link
Owner

Released as part of 9.4.10.

@tlambert03
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants