Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed autofix breaks heredoc #2498

Closed
BackEndTea opened this issue May 9, 2019 · 1 comment
Closed

Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed autofix breaks heredoc #2498

BackEndTea opened this issue May 9, 2019 · 1 comment
Labels
Type: bug
Projects
PHPCS v3 Development
Milestone
3.5.0

Comments

@BackEndTea
Copy link

Given the following code

        yield 'stuff' => [<<<JSON
{
}
JSON
        ];

It gets fixed to

        yield 'stuff' => [<<<JSON
{
}
JSON];

Which breaks, because it cuts off the heredoc.
@gsherwood gsherwood added this to Backlog in PHPCS v3 Development via automation May 13, 2019
@gsherwood gsherwood added this to the 3.5.0 milestone May 13, 2019
@gsherwood gsherwood changed the title Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed breaks heredoc Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed autofix breaks heredoc May 13, 2019
gsherwood added a commit that referenced this issue May 13, 2019
@gsherwood
Fixed bug #2498 : Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed a…
6868096 
…utofix breaks heredoc
@gsherwood
Copy link
Member

This will be fixed in 3.5.0. Thanks for reporting.

PHPCS v3 Development automation moved this from Backlog to Ready for Release May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
PHPCS v3 Development
Ready for Release
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@gsherwood @BackEndTea