Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala linter to CI #49

Open
2 tasks done
bzz opened this issue Mar 6, 2018 · 4 comments
Open
2 tasks done

Add Scala linter to CI #49

bzz opened this issue Mar 6, 2018 · 4 comments
Assignees

Comments

@bzz
Copy link
Contributor

bzz commented Mar 6, 2018

TODO:

  • add/document sbt task with linter and code style
  • integrate linter in CI

As well noted in #48 (review)

I would be nice if all of us use the same configuration for code style.

@carlosms
Copy link
Contributor

It looks like we already have sbt scalastyle in place. As can be seen in travis.yml, and travis logs.

I'll wait for you to close the issue, just in case I misunderstood it and there's something else missing.

@carlosms carlosms removed their assignment Mar 15, 2018
@bzz
Copy link
Contributor Author

bzz commented Mar 16, 2018

Those are basically default InteliJ scala styles. 👍 for importing them to our scalastyle profile, so CI could verify.

@carlosms please feel free to update pr description with your finds/changes in scope.

@bzz
Copy link
Contributor Author

bzz commented Apr 17, 2018

Addressed by #86 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants