Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fails #60

Open
tevino opened this issue Sep 10, 2019 · 3 comments
Open

Make fails #60

tevino opened this issue Sep 10, 2019 · 3 comments

Comments

@tevino
Copy link
Contributor

tevino commented Sep 10, 2019

The make fails on current master.

~/go-license-detector> make
curl -SLk -o license-list-data.tar.gz https://github.com/spdx/license-list-data/archive/v3.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   128    0   128    0     0     79      0 --:--:--  0:00:01 --:--:--    79
100 13.6M  100 13.6M    0     0  2249k      0  0:00:06  0:00:06 --:--:-- 3724k
tar -xf license-list-data.tar.gz license-list-data-3.0/text
tar -xf license-list-data.tar.gz license-list-data-3.0/json/details
go run licensedb/internal/assets/extract_urls.go license-list-data-3.0/json/details > urls.csv
go run licensedb/internal/assets/extract_names.go license-list-data-3.0/json/details > names.csv
tar -cf licenses.tar -C license-list-data-3.0/text .
rm -rf license-list-data-3.0
2019/09/10 14:59:14 Listing license-list-data-3.0/json/details: open license-list-data-3.0/json/details: no such file or directory
exit status 1
2019/09/10 14:59:14 Listing license-list-data-3.0/json/details: open license-list-data-3.0/json/details: no such file or directory
exit status 1
make: *** [names.csv] Error 1
make: *** Waiting for unfinished jobs....
make: *** [urls.csv] Error 1
@tevino
Copy link
Contributor Author

tevino commented Sep 10, 2019

It could be fixed by tevino@51ed166

~/go-license-detector> make
curl -SLk -o license-list-data.tar.gz https://github.com/spdx/license-list-data/archive/v3.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   128    0   128    0     0     72      0 --:--:--  0:00:01 --:--:--    72
100 13.6M  100 13.6M    0     0  2026k      0  0:00:06  0:00:06 --:--:-- 3254k
tar -xf license-list-data.tar.gz license-list-data-3.0/text
tar -xf license-list-data.tar.gz license-list-data-3.0/json/details
tar -cf licenses.tar -C license-list-data-3.0/text .
go run licensedb/internal/assets/extract_urls.go license-list-data-3.0/json/details > urls.csv
go run licensedb/internal/assets/extract_names.go license-list-data-3.0/json/details > names.csv
rm -rf license-list-data-3.0
rm -f license-list-data.tar.gz
/Users/tevin/.gopath/bin/go-bindata -nometadata -pkg assets -o licensedb/internal/assets/bindata.go licenses.tar urls.csv names.csv
rm licenses.tar urls.csv names.csv
rm -rf license-list-data-3.0

@tevino
Copy link
Contributor Author

tevino commented Sep 10, 2019

@vmarkovtsev Please take a look.

@vmarkovtsev
Copy link
Collaborator

Thanks for finding this problem. I commented in the commit you linked to, could you please turn it into a PR?

@tevino tevino mentioned this issue Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants