Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: "token" should be "secret" #64

Open
gilgongo opened this issue Mar 3, 2021 · 1 comment
Open

Docs: "token" should be "secret" #64

gilgongo opened this issue Mar 3, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@gilgongo
Copy link

gilgongo commented Mar 3, 2021

Hi - Just a minor thing, but When it says:

"Generate a token from the Organisation settings or User Settings "

It would be clearer as:

"Generate a secret from the Organisation settings or User Settings "

There is no item for "tokens" in the GitHub menu (nor do they refer to creating tokens in their documentation).

EDIT: But wait... what's this #61 ?

@gilgongo gilgongo changed the title Docs: "token" sould be "secret" Docs: "token" should be "secret" Mar 3, 2021
@srggrs
Copy link
Owner

srggrs commented Mar 7, 2021

Hi @gilgongo

I developed the main code of this action more than a years ago and seems the way the action runs with the secrets changed a bit ever since. Now seems you do not need to generate a Personal Access Token and use the statement GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} in your workflow file for personal repositories projects (projects that are in your personal repositories), though my action does not reflect this just yet. In any case for projects that belong to an organisation (not personal), you need to generate a Personal Access Token with org permissions (see #58) and use it in your workflow file MY_GITHUB_TOKEN: ${{ secrets.MY_GITHUB_TOKEN }} where MY_GITHUB_TOKEN is the name of the newly generated token.

Hope that is clear.

I'm planning to remove the secrets.GITHUB_TOKEN from the action for personal projects.

Cheers,
Sergio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants