New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `routeUri` #156

Open

srid opened this issue Apr 28, 2020 · 0 comments

Owner

srid commented Apr 28, 2020 •

edited

Like routeUrl but returns Text.URI.URI (constructured properly without HasCallStack)

cf. https://github.com/srid/neuron/pull/147/files#diff-0a2c15e31c048b676c97d761d186541fR59-R66

Then re-implement routeUrl using the URI.

Consider passing a parameter that can take the site base url (needed for neuron):

newtype BaseUrl = BaseUrl { unBaseUrl :: URI } -- Use smart constructor to ensure it is absolute
data UrlType
  = AbsoluteUrl BaseUrl
  | RelativeUrl 
  | RelativeUrlFromRoot

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment