Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to auto add custom tag options fields #41

Closed
PramodChaitanyakvv opened this issue Jul 27, 2023 · 2 comments
Closed

Support to auto add custom tag options fields #41

PramodChaitanyakvv opened this issue Jul 27, 2023 · 2 comments

Comments

@PramodChaitanyakvv
Copy link

PramodChaitanyakvv commented Jul 27, 2023

The current library supports adding custom tags automatically but doesn't support auto adding custom tag options automatically. Can we add the following feature to auto add custom tag options along with custom tags?

Current library support:

execution of this command will generate following structs

protoc -I /usr/local/include \
    	-I . \
    	--gotag_out=auto="form-as-camel":. example/example.proto
  

Generated Go structs
  
type Foo struct {
	Id   string `form:"id"`
	Name string `form:"name"`
	Age  int    `form:"age"`
}

Requested feature

auto add custom tag options to "form" tag in above struct
 
Expected Generated Go structs
 
type Foo struct {
	Id   string `form:"id,omitempty,optional"`
	Name string `form:"name,omitempty,optional"`
	Age  int    `form:"age,omitempty,optional"`
}
@Kavuti
Copy link
Collaborator

Kavuti commented May 10, 2024

Is this issue still relevant?
Me, @ucpr and @mesmerx are embracing the project and planning both maintenance and evolution, so we would like to tidy up everything before working on new features. If the issue is not relevant anymore or we don't get a response in a few days, it will be closed, until we are ready to work on it.

@Kavuti
Copy link
Collaborator

Kavuti commented May 27, 2024

The issue will be closed due to inactivity. It may be reopened in the future when the rework will be stable.

@Kavuti Kavuti closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants