Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure work items #1259

Open
4 tasks
Rob-Hague opened this issue Dec 2, 2023 · 5 comments
Open
4 tasks

Infrastructure work items #1259

Rob-Hague opened this issue Dec 2, 2023 · 5 comments

Comments

@Rob-Hague
Copy link
Collaborator

Let's discuss and coordinate ideas here to avoid crossing or unnecessary work. Feel free to add to (or remove from) the list.

@scott-xu
Copy link
Collaborator

scott-xu commented Dec 3, 2023

@jacobslusser
Copy link
Contributor

  • Drop support for net462 and netstandard2.0 (and maybe even netstarndard2.1)

There are code improvements I would like to make but are much more challenging to do when having to support these legacy runtimes/standards. Anyone who wishes to use those runtimes stays on the 2023.x version.

@Rob-Hague
Copy link
Collaborator Author

Long term that is the plan, but right now there is still plenty of scope for modernisation and bug fixes with the current targets. The library has only just dropped support for silverlight 😉

@jacobslusser
Copy link
Contributor

I won't argue the point, but for me there is no harm in freezing those older runtimes at this version. If additional bug fixes or security items are found, then we simply support those on a releases/2023.x branch. I'm personally feeling the pain of these old frameworks as I work on "async all the way down" and modern logging implementations, both of which get significant enhancements in later versions of the runtimes and are requiring a lot of conditional compilation to make them work.

Please consider it, as I said, I don't see a downside to doing that, and it is directly impacting the modernization efforts.

P.S. - I'll only recently took an interest in contributing to this project, so you are free to ignore anything I say. 😁

@Rob-Hague
Copy link
Collaborator Author

If additional bug fixes or security items are found, then we simply support those on a releases/2023.x branch

IMO this is too much effort on behalf of the (not even a) handful of contributors.

"Async all the way down" is already possible with the current targets (I have been thinking about it lately). A few conditional directives are no problem.

Sure, keeping these targets makes some shiny features prohibitive, but (IMHO) there is much more work that should take priority.

It will surely happen one day, but given the current position of the library, I do see the downsides and very few upsides.

You are of course free to modify your own fork as you please.

P.S. - I'll only recently took an interest in contributing to this project, so you are free to ignore anything I say. 😁

Your interest is welcome :) As I said, there is lots of work to choose from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants