Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for the signer race condition fixed in #4738 #4747

Open
obycode opened this issue May 3, 2024 · 0 comments
Open

Add a test case for the signer race condition fixed in #4738 #4747

obycode opened this issue May 3, 2024 · 0 comments

Comments

@obycode
Copy link
Contributor

obycode commented May 3, 2024

I think that we want to make sure in a realistic testing environment that signers are able to sign new blocks during the 0th tenure of a reward cycle. If there's a race condition in the /v2/pox endpoint which prevents it from updating on time, its possible it could trigger "off by one" like behavior for the 0th tenure. I think this patch fixes that, but its something we want to be sure to confirm.

Originally posted by @kantai in #4738 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

2 participants