Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacks-signer] add reward cycle number to all stackerdb messages to prevent new signers reading old data #4755

Open
jferrant opened this issue May 6, 2024 · 0 comments
Assignees
Labels
3.1 bug Unwanted or unintended property causing functional harm nakamoto

Comments

@jferrant
Copy link
Collaborator

jferrant commented May 6, 2024

Currently this behaviour has been observed:

Signers N-1 come online. Read stackerdb. See nothing. do DKG,
Signers N come online. Read stackerdb. See nothing. do DKG
Signers N+1 come online. Read stackerdb. See Signers N-1 DKG and apply it. Then fail because they get the same key or fail to do DKG because signers keys have changed, and do DKG again.

Now that signers reread stackerdb messages on spin up (in case they missed incoming messages), they need to make sure that the messages they are reading belong to their own reward cycles. The stackerdb messages currently reuse stackerdb slots which can result in old reward cycle data being reread and applied to the wrong reward cycle

@jferrant jferrant added bug Unwanted or unintended property causing functional harm nakamoto 3.0-must labels May 6, 2024
@jferrant jferrant self-assigned this May 6, 2024
@jferrant jferrant added 3.1 and removed 3.0-must labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1 bug Unwanted or unintended property causing functional harm nakamoto
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant