Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in nakamoto_tenures table #4786

Closed
obycode opened this issue May 13, 2024 · 2 comments · Fixed by #4812
Closed

Fix typo in nakamoto_tenures table #4786

obycode opened this issue May 13, 2024 · 2 comments · Fixed by #4812
Assignees

Comments

@obycode
Copy link
Contributor

obycode commented May 13, 2024

Describe the bug
There is a typo in the definition of the nakamoto_tenures table:

It didn't cause any problems because it seems that sqlite will default to NUMERIC type if it can't figure it out. Despite that, this typo should be fixed. Since this is already released with the typo, we might need to be careful about just changing the schema.

@obycode
Copy link
Contributor Author

obycode commented May 14, 2024

@kantai mentioned that https://www.sqlite.org/stricttables.html would have caught this.

@kantai
Copy link
Member

kantai commented May 14, 2024

Yep -- I think the appropriate thing to do in this case, is to drop the table and recreate it with a schema version number switch. Because no entries in this table exist yet, this is safe.

This should be a good first use case for the STRICT keyword in the recreated table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants