Clarity WG Meeting Minutes

[setzeus]

Clarity WG Meeting Minutes Thread

The Clarity WG working group will have weekly meeting notes posted here in minimal detail. We encourage anyone excited to participate to check out our Introduction To The Clarity WG discussion as well as the following project board:

Clarity WG Project Board

We meet on both Tuesdays & Thursday. This particular Discussion thread will be appended after every meeting with meeting minutes (aka notes).

[setzeus]

October 19th, 2023

Attended
@setzeus , @MarvinJanssen , @jo-tm

Discussed
Relatively short meeting minutes since a few people weren't in attendance and/or traveling for the hackathon.

• Discussed generalized commit-reveal progress for Clarity-Bitcoin
• Discussed post-security suggestions for Clarity-Bitcoin

To-Do

• Re-engage with Signer WG for DB contracts
• Work on Minimum Deposit Value open issue

[setzeus]

October 24th, 2023

Attended
@setzeus , @MarvinJanssen , @moodmosaic

Discussed
Reviewed open issues in project board & made discussed the work done on commit-reveal & how it works with op_code.

To-Do

• Move to Tuesday & Fridays at 8:30 am EST
• Mocked/simulated transactions & history of them

[setzeus]

October 27th, 2023

Attended
@setzeus , @MarvinJanssen , @moodmosaic, @FriendsFerdinand

Discussed
Reviewed open issues in project board & once again discussed Drop vs. Return comments. @FriendsFerdinand explained his latest POC which is noted below:

"1 Bitcoin transaction & 1 Stacks transaction
1 Bitcoin Commit transaction
The Bitcoin does go directly to the peg-wallet in the first transaction
Commit has the address
Reveal has the data that verifies that goes into it
The address is two tap leaves
1st script is locking the stacks to the stackers key
2nd script is claw-back"

To-Do

• Further SIP research

[setzeus]

October 31st, 2023

Attended
@setzeus, @moodmosaic

Discussed
Reviewed open issues in project board & discussed newly-opened issues that surfaced from last weeks SIP #25 research review.

Also listed out explicit differences between current & next version of asset contract:

1. Mint function
2. Burn function
3. Extract out sBTC-DB

To-Do

• Start assigning Clarity issues to Nikos :)
• Plan out sBTC Educational Series (1 contract(s) per IC)?

[setzeus]

November 7th, 2023

Attended
@setzeus, @moodmosaic, @MarvinJanssen, @jo-tm, @friedger

Discussed
Reviewed the sBTC Clarity Design doc probing for remaining unanswered design questions.

Currently the biggest remaining item comes from the voting mechanisms.

To-Do

• Finish sBTC Clarity design
• Write up design issues
• Assign / delegate out designs issues

[setzeus]

November 18th, 2023

Attended
@setzeus, @moodmosaic, @MarvinJanssen

Discussed
Shift in priorities post Austin IRL meeting. We reviewed all the tickets/issues opened during the week in anticipation of PoX-4 work.

Current focus is to answer any unanswered questions in tickets & start assigning them.

To-Do

• Assign / delegate out tickets

[setzeus]

November 14th - 17th, 2023

Discussed
After many in-person discussions that stemmed from the Nakamoto review, it's become crystal clear that our priority is to support Nakamoto as much as we can.

What does this mean for us?
In short, it means that the immediate priority is to contribute to PoX-4 implementation & testing efforts. We spent days reviewing open-tickets that can be found here & will be delegated out shortly.

While the strict focus will be PoX-4, any leftover resources will go towards continuing the momentum we have in the sBTC track.

[moodmosaic]

[..]priority is to contribute to PoX-4 implementation & testing efforts

What's the latest status of testing in PoX-4? /cc @kantai

[setzeus]

November 21st, 2023

Attended
@setzeus @moodmosaic @MarvinJanssen @friedger

Discussed
After a heavy week of research, discussion & documentation we landed on a series of ticket for Nakamoto / Argon that revolve around the work needed for PoX-4.

The biggest take-away is this design doc that outlines all the issues mentioned & maps them to design reasons. We've reviewed this as a working group & have a few amount of open-questions remaining. Once clear, which we expect in the next 24-48 hours, we will kickoff the engineering part of this sprint.

Nakamoto Clarity (PoX-4) Design

[setzeus]

November 24th, 2023

Attended
@setzeus @moodmosaic @MarvinJanssen @friedger

Discussed
During this meeting we assigned & discussed Nakamoto/Argon tickets for improvements to PoX-4 that were discussed here.

During this meeting Nikos also flagged that he needed write access to the stacks-core repo.

[setzeus]

November 28th, 2023

Attended
@setzeus @MarvinJanssen @friedger

Discussed
The focus of this meeting revolved around both Argon/Nakamoto tickets as well as Clarity-Bitcoin-v5 code coverage.

In the former, Friedger & Nikos have began work on standing up a more robust Clarinet-based setup so that we have both Rust & Clarinet testing environments; Setzeus started work on a series of issues that focus on registering a signer key.

In the latter, Marvin completed test coverage on Clarity-Bitcoin-v5 & was successfully merged in!

Clarity Bitcoin

[moodmosaic]

@setzeus @friedger if we're going to fuzz and property-test the current parser, do we have a GH issue for it? Assign to me please. 🚀

[MarvinJanssen]

No issue yet so feel free to create it!

[moodmosaic]

@MarvinJanssen, probably we'll just add those in @friedger's PR stacks-network/stacks-core#4100 and be done. I just added a few in stacks-network/stacks-core@3e9b3af with more to come.

[setzeus]

December 1st, 2023

(copied over from ClarityWG working doc)

Attended
@setzeus @moodmosaic @friedger

Discussed
On-going PRs with Friedger moving onto aggregate public key items, Nikos going through the pox_3_test.rs tests, & Setzeus working on the register signing-keys PR.

[setzeus]

December 5th, 2023

(copied over from ClarityWG working doc)

Attended
@setzeus @MarvinJanssen @friedger

Discussed
On-going PRs in Argon/PoX-4. Open questions we discussed:

• Using cycles vs. at-block
• Whether 1 or 2 StackerDBs are needed due to overlap during prepare phase

Aggregate PubKey
Discussed ways the to cryptographically-verify that the KeyPath can't be spent

Testing

• Worked with @jbencin to update existing PoX-4 tests to include a registered signer-key

[setzeus]

December 8th, 2023

(copied over from ClarityWG working doc)

Attended
@setzeus @MarvinJanssen @moodmosaic @friedger

Discussed
Marvin Updates

• Opened issue on two stacker-DBs
• Opened issue on unspendable KeyPath
• Discussed generalized commit-reveal

Friedger Updates

• Waiting for reviews on open PRs
• Unclear on next steps for voting mechanism

To-Do

• Meet with Jacinta/Jude re: Stacker-DB (x2)
• Create tests for Clariety parser in rolled test framework

[setzeus]

December 11th, 2023

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen jferrant jcnelson

Notes
Three sets

• Current set of stackers
• One coming online
• Miners

How many slots exactly will a stacker need to carry out DKG?

• Currently 10, 9 of which are for DKG, 1 is for block proposal back to the miner

What is the total number of slots assigned to a signer?
What is the index?
Do I have write access to an ID?

stackslib/src/net/stacker-db/config.rs

• Check comments in 17 - 32 & make sure those functions & signatures make it into pox-4
• Can use custom maps as long as the return-type / implementations are correct

Reverting back to one stacker-db
We have stop using block-height & we have to figure out how to migrate
Going to need an sBTC-DB

[setzeus]

December 11th, 2023

(copied over from ClarityWG working doc)

Agenda:

• Review #4092 tests
• Review #4164 type-check
• PoX4 disallow-during-prepare-phases
• Fuzzing for whole stacks-core repo

Friedger

• Learned how signer work

Marvin

• Using sBTC as a mining topic
• Review PRs
• How they’re going to populate the data (back to 10 slots again)

To-Do:

• Meet up w/ Jeff
• The ‘revoke prepare phase’ includes a working checker for Clarinet Checkn
• Tie in together PoX-4 with a signer
• There is a signer-test file but it just mocks PoX-4

[setzeus]

December 19th, 2023

(copied over from ClarityWG working doc)

Review PR Order

1. #4094 -> (get in asap)
2. #4157
3. #4092
4. #4163
5. #4164

What if we do the PRs in order of the user-flow?

What to do with 4100? (talk to JW)

[setzeus]

December 20th, 2023

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen jwiley friedger

Agenda

• New repo or an existing tooling / repo
  2.1 Testing(?)
• Running these clarinet tests in CI is no problem
• https://github.com/hirosystems/stacks-e2e-testing
• https://github.com/stacks-network/stacks-test-scripts-2.1
• https://github.com/stacks-network/actions
• All the scripts, parser, & the scripts that generate the tests (not the tests themselves)
• Use existing JSON
• We’re going to use a new repo

[setzeus]

December 20th, 2023

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen friedger

Notes
Review Setzeus on-going

• Clarity tests (running into boundaries, need to document)
• Signer set logic (on PR #4160)

Review Marvin on-going

• Blocked on outstanding PR waiting to be merged
• Going to work b/w Stacker-DB & node

Review Nikos on-going

• POC fuzzer for JSON rpc

[setzeus]

January 5th, 2024

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen

Agenda
Review Setzeus on-going

• Clarity tests (running into boundaries, need to document)
• Signer set logic (on PR #4160)

Review Marvin on-going

• .Stackers that instantiates in the right epoch
• Going to work b/w Stacker-DB & node

Review Nikos on-going

• POC fuzzer for JSON rpc

To-Do
Review Setzeus on-going

• Marvin / StackerDB, Stacker contract only a trait & data map updated by the node
• Ping Jacinta to clarify #3980 & #4058 - are they duplicate?
• Why are some checks in Clarity & some in the Node?
• Can we standardize how we split these responsibilities?

[setzeus]

January 9th, 2024

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen moodmosaic

Agenda
Review Setzeus on-going

• Possible to write another RegTest test versions?
• Possible to append mock functions to the end of pox-4

Review Marvin on-going

• Two block-producing functions (setup_block)
• Updating tests helper due to confusion with two setup_blocks
• Eval_read_only or maybe_read_only

Review Nikos on-going

• RPC node fuzzing

[setzeus]

January 12th, 2024

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen friedger

Agenda
Review Setzeus on-going

• Tests, tests, tests

Review Marvin on-going

• .Signer work almost finished with PR will almost be up
• Rust base tests do not need to be updated

Review Nikos on-going

• One in merged-in
• One is still pending

To-Do

• How many blocks per tenure?
• Is there a max number of blocks per tenure?

[setzeus]

January 19th, 2024

(copied over from ClarityWG working doc)

Attended
@setzeus @MarvinJanssen @friedger

Agenda
Review Setzeus on-going

• Tests, tests, tests

Review Marvin on-going

• Wanted to be able to do full round-trip
• Can boot nakamoto, can stack w/ stackers, can put in signers keys, read prepare phase…verify the signers are in there
  4247
• What if you partially commit w/ same key? Check if key is new or within the current cycle
• Appears that tests are sometimes flaky
• The PoX-4 reward set & signer set should be more tightly coupled (currently not)
• Add some funcs that are not stacker-db specific

Review Friedger

• Issue 4247: signature from public key which includes something like principal + current reward cycle
• Signers can re-choose blocks if they don’t agree on it
• Priority should be given to control plane
• 2.5 is when a key should be decided, 3.0 is when an aggregate key-pub
• Friedger unblocked!
• Must submit a signed message with the signer-key

To-Do

• How exactly do you calculate the reward set?
• Might split PR so he has a mocked .signers?
• What is the connection b/w signer keys, pox address & the stacker - how do they play together?
• Control of the signing-key (issue #4247)

[setzeus]

January 23rd, 2024

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen moodmosaic

Agenda
Review Setzeus on-going

• Reviewing aggregate public key PR

Review Marvin on-going

• Not concerned about finishing code completion items
• Adding key to the reward set
• All the items are there, just refactoring left

Review Friedger

• Fuzzing tool for ClarityWASM

[setzeus]

January 24th, 2024

(copied over from ClarityWG working doc)

Attended
setzeus jferrant friedger

Agenda
Where to branch-off for aggregate public key vote?

• Based off of Marvins
• Which is based off of Aarons...
• Which is based off of Next...

[setzeus]

January 26th, 2024

(copied over from ClarityWG working doc)

Attended
@setzeus @MarvinJanssen @friedger

Agenda
WG Overall Update

• Our deadlines got moved up / we're now blocking other WGs
• Poor design / planning contributed
• Need to have better tasks scoping
• Some PRs waiting for way too long
• Issues were not well defined
• Missing Gantt chart could've highlighted WG blocks
• Need to raise flags faster on issues not resolved
• Too complex to have laid out in one-go

Review Marvin On-Going

• Once BitVec is merged, Marvin can add the items Friedger needs for voting
• Map inside Clarity written into the
• Will branch off of BitVec

Review Friedger On-Going

• Friedger mocks one signer slot per each stacker
• Can we test the whole end-to-end, she doesn’t know the test for voting because
• Jacinta waiting until Aaron’s PR is merged
• Needs number of slots per stacker
• Rebasing again off of BitVec…

[setzeus]

February 2nd, 2024

(copied over from ClarityWG working doc)

Attended
setzeus MarvinJanssen friedger

Agenda
Review Jesus

• Update clarunit to include
• Poor design / planning

Review Friedger

• Bring up w/ Jude what’s the latest issue on the accept out-of-order-votes
• Waiting on comments for the out-of-order votes
• Wants to learn so can signer & run some test
• Aggregate public key (buff 33), principal, & a point

Review Marvin

• Nothing on Argon
• Might pick up a post-condition issue (the max size it can represent vs. clarity uint value)
• Happy to test in either clarity or rust
• List out the different situations, using signing-keys, reusing them, different groups of signers, pools, items like that

Improvements For sBTC

• Model of where we see how it goes
• Simulations where we walk through designs would be helpful
• What is the current spec of sBTC?
• We need a centralized spec that’s updated continuously
• Igor did a good job of this for a majority of sBTC work

[setzeus]

February 9th, 2024

(copied over from ClarityWG working doc)

Attended
setzeus brice nikos friedger

Agenda
Review Brice

• Will put up a PR soon that closes out multiple PRs
• Including Friedger’s out-of-order
• Maybe more documentation updates

Review Friedger

• Need more stacking / locked-stacks information for testing
• Can’t test private functions
• Update Hiro E2E Testing
• buildDevnetNetworkOrchestrator

Review Nikos

• Next week kicking off PoX-4

Review Jesus

• Working on signers-voting Rust tests