Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello Blockstack generates invalid auth request token #416

Open
kantai opened this issue Feb 14, 2018 · 4 comments
Open

Hello Blockstack generates invalid auth request token #416

kantai opened this issue Feb 14, 2018 · 4 comments

Comments

@kantai
Copy link
Member

kantai commented Feb 14, 2018

The auth request token generated by Hello Blockstack is invalid:

I see this code on helloblockstack.com

document.getElementById('signin-button').addEventListener('click', function(event) {
    event.preventDefault()
    var appDomain = window.location.hostname
    var privateKey =  null
    var authRequest = blockstack.makeAuthRequest(privateKey, appDomain)
    blockstack.redirectUserToSignIn(authRequest)
  })

The null private key makes the auth window fail to load the app manifest.

@kantai
Copy link
Member Author

kantai commented Feb 14, 2018

Tagging @larrysalibra and @yknl because I'm not sure who is operating helloblockstack.com

@larrysalibra
Copy link
Contributor

@kantai I also don't know who runs it.

@jackzampolin @shea256 ?

@jackzampolin
Copy link
Contributor

not me 🤷‍♂️

@yknl
Copy link
Collaborator

yknl commented Feb 14, 2018

it's not me either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants