55 "errors"
66 "fmt"
77 "os"
8+ "regexp"
9+ "strconv"
10+ "strings"
811
912 "github.com/prometheus/client_golang/prometheus"
1013 "github.com/sirupsen/logrus"
@@ -16,9 +19,9 @@ import (
1619 "github.com/stakater/Reloader/internal/pkg/util"
1720 "github.com/stakater/Reloader/pkg/kube"
1821 v1 "k8s.io/api/core/v1"
19- "regexp "
20- "strconv "
21- "strings "
22+ "k8s.io/apimachinery/pkg/api/meta "
23+ "k8s.io/apimachinery/pkg/runtime "
24+ "k8s.io/client-go/tools/record "
2225)
2326
2427// GetDeploymentRollingUpgradeFuncs returns all callback funcs for a deployment
@@ -91,31 +94,31 @@ func GetArgoRolloutRollingUpgradeFuncs() callbacks.RollingUpgradeFuncs {
9194 }
9295}
9396
94- func doRollingUpgrade (config util.Config , collectors metrics.Collectors ) error {
97+ func doRollingUpgrade (config util.Config , collectors metrics.Collectors , recorder record. EventRecorder ) error {
9598 clients := kube .GetClients ()
9699
97- err := rollingUpgrade (clients , config , GetDeploymentRollingUpgradeFuncs (), collectors )
100+ err := rollingUpgrade (clients , config , GetDeploymentRollingUpgradeFuncs (), collectors , recorder )
98101 if err != nil {
99102 return err
100103 }
101- err = rollingUpgrade (clients , config , GetDaemonSetRollingUpgradeFuncs (), collectors )
104+ err = rollingUpgrade (clients , config , GetDaemonSetRollingUpgradeFuncs (), collectors , recorder )
102105 if err != nil {
103106 return err
104107 }
105- err = rollingUpgrade (clients , config , GetStatefulSetRollingUpgradeFuncs (), collectors )
108+ err = rollingUpgrade (clients , config , GetStatefulSetRollingUpgradeFuncs (), collectors , recorder )
106109 if err != nil {
107110 return err
108111 }
109112
110113 if kube .IsOpenshift {
111- err = rollingUpgrade (clients , config , GetDeploymentConfigRollingUpgradeFuncs (), collectors )
114+ err = rollingUpgrade (clients , config , GetDeploymentConfigRollingUpgradeFuncs (), collectors , recorder )
112115 if err != nil {
113116 return err
114117 }
115118 }
116119
117120 if options .IsArgoRollouts == "true" {
118- err = rollingUpgrade (clients , config , GetArgoRolloutRollingUpgradeFuncs (), collectors )
121+ err = rollingUpgrade (clients , config , GetArgoRolloutRollingUpgradeFuncs (), collectors , recorder )
119122 if err != nil {
120123 return err
121124 }
@@ -124,17 +127,17 @@ func doRollingUpgrade(config util.Config, collectors metrics.Collectors) error {
124127 return nil
125128}
126129
127- func rollingUpgrade (clients kube.Clients , config util.Config , upgradeFuncs callbacks.RollingUpgradeFuncs , collectors metrics.Collectors ) error {
130+ func rollingUpgrade (clients kube.Clients , config util.Config , upgradeFuncs callbacks.RollingUpgradeFuncs , collectors metrics.Collectors , recorder record. EventRecorder ) error {
128131
129- err := PerformRollingUpgrade (clients , config , upgradeFuncs , collectors )
132+ err := PerformRollingUpgrade (clients , config , upgradeFuncs , collectors , recorder )
130133 if err != nil {
131134 logrus .Errorf ("Rolling upgrade for '%s' failed with error = %v" , config .ResourceName , err )
132135 }
133136 return err
134137}
135138
136139// PerformRollingUpgrade upgrades the deployment if there is any change in configmap or secret data
137- func PerformRollingUpgrade (clients kube.Clients , config util.Config , upgradeFuncs callbacks.RollingUpgradeFuncs , collectors metrics.Collectors ) error {
140+ func PerformRollingUpgrade (clients kube.Clients , config util.Config , upgradeFuncs callbacks.RollingUpgradeFuncs , collectors metrics.Collectors , recorder record. EventRecorder ) error {
138141 items := upgradeFuncs .ItemsFunc (clients , config .Namespace )
139142
140143 for _ , i := range items {
@@ -177,17 +180,29 @@ func PerformRollingUpgrade(clients kube.Clients, config util.Config, upgradeFunc
177180 }
178181
179182 if result == constants .Updated {
183+ accessor , err := meta .Accessor (i )
184+ if err != nil {
185+ return err
186+ }
187+ resourceName := accessor .GetName ()
180188 err = upgradeFuncs .UpdateFunc (clients , config .Namespace , i )
181- resourceName := util .ToObjectMeta (i ).Name
182189 if err != nil {
183- logrus .Errorf ("Update for '%s' of type '%s' in namespace '%s' failed with error %v" , resourceName , upgradeFuncs .ResourceType , config .Namespace , err )
190+ message := fmt .Sprintf ("Update for '%s' of type '%s' in namespace '%s' failed with error %v" , resourceName , upgradeFuncs .ResourceType , config .Namespace , err )
191+ logrus .Errorf (message )
184192 collectors .Reloaded .With (prometheus.Labels {"success" : "false" }).Inc ()
193+ if recorder != nil {
194+ recorder .Event (i , v1 .EventTypeWarning , "ReloadFail" , message )
195+ }
185196 return err
186197 } else {
187- logrus .Infof ("Changes detected in '%s' of type '%s' in namespace '%s'" , config .ResourceName , config .Type , config .Namespace )
188- logrus .Infof ("Updated '%s' of type '%s' in namespace '%s'" , resourceName , upgradeFuncs .ResourceType , config .Namespace )
198+ message := fmt .Sprintf ("Changes detected in '%s' of type '%s' in namespace '%s'" , config .ResourceName , config .Type , config .Namespace )
199+ message += fmt .Sprintf (", Updated '%s' of type '%s' in namespace '%s'" , resourceName , upgradeFuncs .ResourceType , config .Namespace )
200+ logrus .Infof (message )
189201 collectors .Reloaded .With (prometheus.Labels {"success" : "true" }).Inc ()
190202 alert_on_reload , ok := os .LookupEnv ("ALERT_ON_RELOAD" )
203+ if recorder != nil {
204+ recorder .Event (i , v1 .EventTypeNormal , "Reloaded" , message )
205+ }
191206 if ok && alert_on_reload == "true" {
192207 msg := fmt .Sprintf (
193208 "Reloader detected changes in *%s* of type *%s* in namespace *%s*. Hence reloaded *%s* of type *%s* in namespace *%s*" ,
@@ -271,7 +286,7 @@ func getContainerWithEnvReference(containers []v1.Container, resourceName string
271286 return nil
272287}
273288
274- func getContainerUsingResource (upgradeFuncs callbacks.RollingUpgradeFuncs , item interface {} , config util.Config , autoReload bool ) * v1.Container {
289+ func getContainerUsingResource (upgradeFuncs callbacks.RollingUpgradeFuncs , item runtime. Object , config util.Config , autoReload bool ) * v1.Container {
275290 volumes := upgradeFuncs .VolumesFunc (item )
276291 containers := upgradeFuncs .ContainersFunc (item )
277292 initContainers := upgradeFuncs .InitContainersFunc (item )
@@ -310,15 +325,15 @@ func getContainerUsingResource(upgradeFuncs callbacks.RollingUpgradeFuncs, item
310325 return container
311326}
312327
313- func invokeReloadStrategy (upgradeFuncs callbacks.RollingUpgradeFuncs , item interface {} , config util.Config , autoReload bool ) constants.Result {
328+ func invokeReloadStrategy (upgradeFuncs callbacks.RollingUpgradeFuncs , item runtime. Object , config util.Config , autoReload bool ) constants.Result {
314329 if options .ReloadStrategy == constants .AnnotationsReloadStrategy {
315330 return updatePodAnnotations (upgradeFuncs , item , config , autoReload )
316331 }
317332
318333 return updateContainerEnvVars (upgradeFuncs , item , config , autoReload )
319334}
320335
321- func updatePodAnnotations (upgradeFuncs callbacks.RollingUpgradeFuncs , item interface {} , config util.Config , autoReload bool ) constants.Result {
336+ func updatePodAnnotations (upgradeFuncs callbacks.RollingUpgradeFuncs , item runtime. Object , config util.Config , autoReload bool ) constants.Result {
322337 container := getContainerUsingResource (upgradeFuncs , item , config , autoReload )
323338 if container == nil {
324339 return constants .NoContainerFound
@@ -370,7 +385,7 @@ func createReloadedAnnotations(target *util.ReloadSource) (map[string]string, er
370385 return annotations , nil
371386}
372387
373- func updateContainerEnvVars (upgradeFuncs callbacks.RollingUpgradeFuncs , item interface {} , config util.Config , autoReload bool ) constants.Result {
388+ func updateContainerEnvVars (upgradeFuncs callbacks.RollingUpgradeFuncs , item runtime. Object , config util.Config , autoReload bool ) constants.Result {
374389 var result constants.Result
375390 envVar := constants .EnvVarPrefix + util .ConvertToEnvVarName (config .ResourceName ) + "_" + config .Type
376391 container := getContainerUsingResource (upgradeFuncs , item , config , autoReload )
0 commit comments