Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support record event #343

Merged
merged 1 commit into from
Oct 4, 2022
Merged

support record event #343

merged 1 commit into from
Oct 4, 2022
+468 −288

Conversation

junnplus
Copy link
Contributor

Signed-off-by: Ye Sijun junnplus@gmail.com

@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-a4ebcfc0

@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-8436b928

@tanalam2411 tanalam2411 added the kind/enhancement New feature or request label Sep 22, 2022
@stakater-user
Copy link
Contributor

@junnplus Yikes! You better fix it before anyone else finds out! Build has Failed!

@tanalam2411
Copy link
Contributor

@junnplus Thanks for this PR, looks interesting but could you please convert it into a draft until you're bringing new changes?

@junnplus junnplus marked this pull request as draft September 22, 2022 16:01
@stakater-user
Copy link
Contributor

@junnplus Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@junnplus Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@junnplus Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@junnplus Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-32f6148e

@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-3644e5c6

@junnplus junnplus marked this pull request as ready for review September 23, 2022 01:38
@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-f025b25f

faizanahmad055
faizanahmad055 requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@faizanahmad055 faizanahmad055 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @junnplus Can you please add these permissions in clusterrole? Also, can you please pull the latest changes from the upstream master and resolve the conflicts if any?

  - apiGroups:
      - ""
    resources:
      - events
    verbs:
      - create
      - patch

@junnplus
support record event

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6937b81 
Signed-off-by: Ye Sijun <junnplus@gmail.com>
@stakater-user
Copy link
Contributor

@junnplus Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-343-6937b812

faizanahmad055
faizanahmad055 approved these changes Oct 4, 2022
View reviewed changes
deployments/kubernetes/chart/reloader/templates/role.yaml
@@ -77,4 +77,11 @@ rules:
- get
- update
- patch
- apiGroups:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this in clusterrole as well

@faizanahmad055 faizanahmad055 merged commit 504b5a8 into stakater:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faizanahmad055 faizanahmad055

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@junnplus @stakater-user @tanalam2411 @faizanahmad055