Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Reloader controller logs #504

Open
SachithKasthuriarachchi opened this issue Jul 31, 2023 · 5 comments
Open

Improve Reloader controller logs #504

SachithKasthuriarachchi opened this issue Jul 31, 2023 · 5 comments
Labels
kind/enhancement New feature or request

Comments

@SachithKasthuriarachchi
Copy link

SachithKasthuriarachchi commented Jul 31, 2023

In my AKS cluster with kubernetes version v1.25.6 the reloader seems to be stuck in the starting controller state.

time="2023-07-31T15:18:54Z" level=info msg="Environment: Kubernetes"
time="2023-07-31T15:18:54Z" level=info msg="Starting Reloader"
time="2023-07-31T15:18:54Z" level=warning msg="KUBERNETES_NAMESPACE is unset, will detect changes in all namespaces."
time="2023-07-31T15:18:54Z" level=info msg="created controller for: configMaps"
time="2023-07-31T15:18:54Z" level=info msg="Starting Controller to watch resource type: configMaps"
time="2023-07-31T15:18:54Z" level=info msg="created controller for: secrets"
time="2023-07-31T15:18:54Z" level=info msg="Starting Controller to watch resource type: secrets"

However, the version v0.0.58 works fine

Helm Values

fullnameOverride: reloader
reloader:
  deployment:
    annotations:
      checkov.io/skip2: CKV_K8S_38=Managed by reloader
    replicas: 1
    securityContext:
      runAsNonRoot: true
      runAsUser: 65534
      seccompProfile:
        type: RuntimeDefault
    image:
      name: ghcr.io/stakater/reloader
      tag: v1.0.32
      pullPolicy: Always
    containerSecurityContext:
      capabilities:
        drop:
          - ALL
      allowPrivilegeEscalation: false
      readOnlyRootFilesystem: true
    resources:
      limits:
        cpu: "100m"
        memory: "512Mi"
      requests:
        cpu: "10m"
        memory: "128Mi"
  readOnlyRootFileSystem: true
@SachithKasthuriarachchi
Copy link
Author

#63

@SachithKasthuriarachchi
Copy link
Author

SachithKasthuriarachchi commented Aug 1, 2023

it seems reloader does not work at all in kubernetes v1.24.9

@SachithKasthuriarachchi
Copy link
Author

@stakater-user do you have an idea about this? the latest 1.0.34 also does not work

@SachithKasthuriarachchi
Copy link
Author

Apologies for this issue. The reloader works fine. I was confused since the log was stopped at the above.

time="2023-07-31T15:18:54Z" level=info msg="Starting Controller to watch resource type: secrets"

Can we improve this log message to say that the controller is started and it is watching the resources?

@bnallapeta
Copy link
Contributor

@SachithKasthuriarachchi We try to follow standard logging that is generally used across k8s products. But feel free to raise a PR to add another log line after the one we already have:

time="2023-07-31T15:18:54Z" level=info msg="Starting Controller to watch resource type: secrets"
time="2023-07-31T15:18:54Z" level=info msg="Started Controller to watch resource type: secrets"

@bnallapeta bnallapeta changed the title Reloader Stuck in Starting Controller State in Versions Higher than v0.0.58 Improve Reloader controller logs Aug 10, 2023
@karl-johan-grahn karl-johan-grahn added kind/enhancement New feature or request and removed good first issue labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants