New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCE]Define memory request and memory limit for reloder-reloader container #639

Open

kunj-bosamia opened this issue Apr 17, 2024 · 1 comment

Labels

good-first-issue kind/enhancement kind/help wanted

kunj-bosamia commented Apr 17, 2024 •

edited

It's a good practice to define memory request and limit for any resource which you deploy on your kubernetes cluster

Solution -> The raw manifest file for reloader provided in the readme file should have memory request and limits defined.

Reference to readme -> https://github.com/stakater/Reloader?tab=readme-ov-file#vanilla-manifests
Raw manifest file -> https://raw.githubusercontent.com/stakater/Reloader/master/deployments/kubernetes/reloader.yaml

kunj-bosamia added the kind/enhancement label

Contributor

MuneebAijaz commented Apr 24, 2024

@kunjbosamiaFalkonry feel free to open a PR for this, these vanilla manifests are created from helm template itself, so it can be overridden there https://github.com/stakater/Reloader/blob/master/.github/workflows/push.yaml#L206

MuneebAijaz added kind/help wanted good-first-issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment