Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(objection): table name 'xxx' specified more than once #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(objection): table name 'xxx' specified more than once #18

wants to merge 1 commit into from

Conversation

MoJo2600
Copy link

When a relation was already joined with withGraphJoined, ucast was adding the relation
a second time. Now a check for the relation is performed.

fixes #17

fix(objection): table name 'xxx' specified more than once
396cec0 
When a relation was already joined with `withGraphJoined`, ucast was adding the relation
a second time. Now a check for the relation is performed.

fixes stalniy#17
@MoJo2600
Copy link
Author

Is there a place to add unit tests for this functionality? I tried pnpm test but it told me that test was not found.

@stalniy
Copy link
Owner

stalniy commented Apr 30, 2021

tests lives in a package folder.

@stalniy
Copy link
Owner

stalniy commented Apr 30, 2021

https://github.com/stalniy/ucast/blob/master/packages/sql/spec/objection.spec.ts

@stalniy stalniy mentioned this pull request Jun 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table name "xxx" specified more than once - objection
2 participants
@MoJo2600 @stalniy