Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraries: implement common set of assertions #10

Open
zekth opened this issue Sep 26, 2023 · 3 comments
Open

libraries: implement common set of assertions #10

zekth opened this issue Sep 26, 2023 · 3 comments
Labels

Comments

@zekth
Copy link
Member

zekth commented Sep 26, 2023

Currently every library defines their own set of test data. eg:

We should at least consider a common set of data to be sure all implementations behave the same.

@tasn tasn added the libs label Sep 26, 2023
@tasn
Copy link
Contributor

tasn commented Sep 26, 2023

I completely agree, and I think they are different across libraries. Though the two examples you shared look identical to me?

@zekth
Copy link
Member Author

zekth commented Sep 27, 2023

Correct, but that would avoid potential drifting between libraries. Just a thought

@tasn
Copy link
Contributor

tasn commented Sep 29, 2023

Oh, sorry, I misunderstood your suggestion. Yes, I agree, the test suite should use a common set of data, and we should read that and validate the same across all of the libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants