Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraries: make a release #11

Open
tasn opened this issue Sep 26, 2023 · 4 comments
Open

libraries: make a release #11

tasn opened this issue Sep 26, 2023 · 4 comments
Labels

Comments

@tasn
Copy link
Contributor

tasn commented Sep 26, 2023

We need to make a release of the libraries

@tasn tasn added the libs label Sep 26, 2023
@pksunkara
Copy link

Would probably need to name the libraries to specify that they only do verification.

@tasn
Copy link
Contributor Author

tasn commented Dec 8, 2023

They also do signing. How would you recommend they should be named? The plan was standard webhooks.

@pksunkara
Copy link

Wouldn't different codebases use those functions? Signing by producer, verifying by the consumer? Small modular libraries are much more preferable similar to how opentelemetry org does things.

@tasn
Copy link
Contributor Author

tasn commented Dec 8, 2023

The code has a lot of overlap, and the same dependencies (cryptography library), so I don't necessarily think splitting it is that useful. On the other hand it saves a lot of operational complexity not having yet another set of libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants