Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quotes are enforced #10

Closed
TimonVS opened this issue Jul 27, 2016 · 4 comments
Closed

Double quotes are enforced #10

TimonVS opened this issue Jul 27, 2016 · 4 comments
Labels

Comments

@TimonVS
Copy link

TimonVS commented Jul 27, 2016

It seems like the jsx-quotes rule was set to enforce double quotes (f85f775).

Shouldn't we be using single quotes? I interpret JSX as JS so I'd use single quotes there too.

@feross
Copy link
Member

feross commented Jul 29, 2016

This was discussed in standard/eslint-config-standard#27 a little while ago. You can take a look at the discussion there and see that we decided to go with double quotes. But standard v8 is still in beta until September 1, 2016 so this might change.

Apologies for not marking the change as beta on this repo as well.

@feross feross closed this as completed Jul 29, 2016
@Nicolab
Copy link

Nicolab commented Sep 14, 2016

Seemingly, the single quotes were chosen in eslint-config-standard-jsx :(
Against the direction of jsx-quotes (double), React dev (double), majority of the React users (double) and the docs in the Web (double), ...

The JSX is written like XML / HTML, not like JS. The single quote rule for the JSX, it's not productive :(

@dcousens
Copy link
Member

dcousens commented Sep 14, 2016

@Nicolab this was no small decision.
standard/standard#564 (comment)

@Nicolab
Copy link

Nicolab commented Sep 14, 2016

I imagine, in this case the easiest way is the more appropriate.
This rule will cause trouble for beginners and majority of users (have to switch between the same conventions of JSX / XML / HTML and this convention).

Now that is done, I override this strange rule and it's no use that I argue more around the single quotes in JSX :)


Sorry for my bad english

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants