Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore and npmrc files #74

Merged
merged 1 commit into from Dec 6, 2022
Merged

Add gitignore and npmrc files #74

merged 1 commit into from Dec 6, 2022

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented Dec 1, 2022

What is the purpose of this pull request? (put an "X" next to item)

[] Documentation update
[] Bug fix
[] New feature
[x] Other, please explain: repository config

What changes did you make? (Give an overview)

I added the node_modules folder to be ignored by Git, since we don't want to commit it.

I told npm to not generate a package-lock file, since this is a library and not an application.

Which issue (if any) does this pull request address?

n/a

Is there anything you'd like reviewers to focus on?

n/a

@welcome
Copy link

welcome bot commented Dec 1, 2022

🙌 Thanks for opening this pull request! You're awesome.

@LinusU LinusU mentioned this pull request Dec 1, 2022
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@LinusU LinusU merged commit 2e2e92c into master Dec 6, 2022
@welcome
Copy link

welcome bot commented Dec 6, 2022

🎉 Congrats on getting your first pull request landed!

@LinusU LinusU deleted the gitignore branch December 6, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants