space-unary-ops errors on new Class() syntax

[bcomnes]

I just noticed today that I started getting space-unary-ops warnings where I shouldn't be getting them like on new Foo() syntax:

I've been running 17.1.0 everywhere for a while now, but this is the first I'm seeing of it. Seems like maybe a transitive broke something.

To reproduce, clear your node_modules and reinstall 17.1.0 and lint a class instantiation.

[missinglink]

This is super broken, it's 'fixing' new String() to newString() 🤦‍♂️

echo "new String()" | npx standard@17.1.0 --stdin --fix
newString()
standard: Use JavaScript Standard Style (https://standardjs.com)
standard:   <text>:1:1: 'newString' is not defined. (no-undef)

echo "new String()" | npx standard@17.1.0 --stdin
standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  <text>:1:1: Do not use String as a constructor. (no-new-wrappers)
  <text>:1:1: Unexpected space before unary operator 'String'. (space-unary-ops)
  <text>:1:1: Do not use 'new' for side effects. (no-new)

[missinglink]

cc/ @voxpelli, this regression was introduced in the latest release.

echo "new String()" | npx standard@17.0.0 --stdin --fix
new String()

echo "new String()" | npx standard@17.1.0 --stdin --fix
newString()

[bcomnes]

@missinglink It seems to be a transitive somewhere in all of the 17 versions. Been running 17.1.0 for a while without issue. npx is likely running cached transitives.

[bcomnes]

Was an issue in acorn:

• acornjs/acorn@7cd08bf
• Current version of ESLint falls apart acornjs/acorn#1252

Re-installing everything and ensuring acorn 8.11.1 is in your tree fixes it.