Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat process.exit() the same as throw in code path analysis rules (node/process-exit-as-throw) #699

Closed
feross opened this issue Nov 23, 2016 · 2 comments
Closed

Treat process.exit() the same as throw in code path analysis rules (node/process-exit-as-throw) #699

feross opened this issue Nov 23, 2016 · 2 comments
Labels
enhancement
Milestone
standard 10

Comments

@feross
Copy link
Member

feross commented Nov 23, 2016

This rule makes process.exit() get treated like a throw, which makes other eslint rules work better.

https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/process-exit-as-throw.md

(This rule depends on eslint-plugin-node, so we should only add it if we're already depending on the plugin due to #693)
@feross
Copy link
Member Author

feross commented Nov 23, 2016

This causes no errors in the test suite.

@feross feross added this to the standard v10 milestone Feb 9, 2017
@feross feross changed the title Make the same code path as throw at process.exit() (process-exit-as-throw) Make the same code path as throw at process.exit() (node/process-exit-as-throw) Mar 2, 2017
@feross feross changed the title Make the same code path as throw at process.exit() (node/process-exit-as-throw) Treat process.exit() the same as throw in code path analysis rules (node/process-exit-as-throw) Mar 2, 2017
@feross
Copy link
Member Author

feross commented Mar 2, 2017

This will be part of the standard v10 beta.

@feross feross closed this as completed Mar 2, 2017
feross added a commit to standard/eslint-config-standard that referenced this issue Mar 2, 2017
@feross
Treat process.exit() the same as throw in code path analysis rules (n…
e5cf63a 
…ode/process-exit-as-throw)

Fixes: standard/standard#699
@feross feross mentioned this issue Mar 2, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
The Standard Project
Archived in project
Milestone
standard 10
Development

No branches or pull requests
1 participant
@feross