Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making standard a peerDependency so the version is controllable by the user #7

Open
timoxley opened this issue Mar 3, 2018 · 9 comments

Comments

@timoxley
Copy link

timoxley commented Mar 3, 2018

As above.

@timoxley
Copy link
Author

timoxley commented Mar 3, 2018

Also may want to consider making standard a peerDependency so the version is controllable by the user? This does make the cli install process a little more clunky, but I don't think it's prohibitively bad.

@Flet
Copy link
Member

Flet commented Mar 5, 2018

Published as standardx@2.0.0

@Flet
Copy link
Member

Flet commented Mar 5, 2018

I'd like to hear some folks thoughts on switching to a peer dependency on standard.

It adds a lot of flexibility, but its also a bit more clunky as you mentioned.

@Flet Flet changed the title Please publish latest version (i.e. add standard 11 support) Consider making standard a peerDependency so the version is controllable by the user Mar 5, 2018
@Flet
Copy link
Member

Flet commented Mar 5, 2018

Updated/hijacked the issue title to "consider making standard a peerDependency so the version is controllable by the user" :)

@Flet
Copy link
Member

Flet commented Mar 5, 2018

any @standard/folks have thoughts?

@LinusU
Copy link
Member

LinusU commented Mar 5, 2018

I think that I think that the most convenient would be if standardx mirrored the versions that standard was published under. That being said, that might not be worth the extra work in setting it up and maintaining it.

Although, just publishing three versions (9.0.0, 10.0.0, and 11.0.0) that all have a caret dependency on the same major (.0.0) would allow the user to select specific version if they want to, but still be able to add this package with just one npm install command.

I don’t have any strong feelings though, this is just my 2¢

@ungoldman
Copy link

ungoldman commented Mar 6, 2018

Agree with @LinusU. It would be nice to install a specific version of standardx that matches a version of standard and avoid the many issues associated with peer dependencies altogether.

Edit: In practice this might not be possible, since standardx may have its own issues and patches that don't correspond to standard at all.

@timoxley
Copy link
Author

timoxley commented Mar 6, 2018

Agreed, that seems like a good middle ground

@brodybits
Copy link

I just discovered this nice repo with this issue, would favor the following alternatives:

  • update standardx to just use standard-engine
  • update standardx to use eslint with eslint-plugin-standard, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants