Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind to "format document" key binding #9

Open
penrillian-chrisa opened this issue Jan 12, 2017 · 6 comments
Open

Bind to "format document" key binding #9

penrillian-chrisa opened this issue Jan 12, 2017 · 6 comments

Comments

@penrillian-chrisa
Copy link

penrillian-chrisa commented Jan 12, 2017

Should this plugin automatically bind to the default "format document" key binding?

(It works just fine in chenxsan.vscode-standard-format)

@chenxsan
Copy link
Member

No, I think it would be confusing when all those plugins automatically bind to the default format document key binding. So it won't be supported unless necessary.

@brucx
Copy link

brucx commented Feb 2, 2018

Would you please consider making this configurable?

@chenxsan
Copy link
Member

chenxsan commented Feb 2, 2018

@brucx haha, I don't find any free time to implement this. You can submit a pull request if you like, I'm willing to merge it.

@falco467
Copy link

Would you please consider making this configurable?

How would that be different from now? The user can just bind the Formatting Hotkey to JS Fix Problems and has the same effect !?

@mcdado
Copy link

mcdado commented Sep 13, 2021

https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

The problem with creating a user shortcut is that is not easily shared between platforms (see Settings Sync) and other developers (shared projects). It would be much nicer to have a proper formatter.

@jurf
Copy link

jurf commented Nov 27, 2021

No, I think it would be confusing when all those plugins automatically bind to the default format document key binding. So it won't be supported unless necessary.

I do not understand. All the extensions I have used (Rust, C++, Java, Python) just plug in into the API – why should this extension be different? VSCode already provides settings to configure formatters per language.

reece-bennett added a commit to reece-bennett/deckhand that referenced this issue Dec 7, 2021
Annoyingly the extension for VSCode doesn't hook into the standard
formatting API but instead uses it's own key bindings so you cannot set
it to format when pressing the format hotkey. Auto fix on save will have
to do for now.

Discussion on the issue tracker here:
standard/vscode-standard#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

7 participants