Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Add native Wayland support such that it doesn't need to be blurry on HiDPI devices #707

Open
2 tasks done
proletarius101 opened this issue May 12, 2021 · 15 comments
Open
2 tasks done

Comments

@proletarius101
Copy link

proletarius101 commented May 12, 2021

Add native Wayland support such that it doesn't need to be blurry on HiDPI devices

  • Update Node to the latest LTS (14.17.0 LTS)
  • Update Electron to the latest stable (12.0.6)
@JaspalSuri
Copy link

Thanks for the suggestions @proletarius101; I'll forward this over to our desktop and web app dev for review. 🙂

@vchernin
Copy link

vchernin commented Jun 19, 2021

Some info about the current situation:

The described blur only occurs when running with GNOME fractional scaling (e.g. 125% scaling not 200%) in Wayland, which is a somewhat experimental feature. Indeed native Wayland support solves that problem though. I see that linked thread is about wlroots, so maybe xwayland apps in HiDPI are always blurry there (so this fix is even more important there).

You will notice on native Wayland in GNOME (Ubuntu, Fedora, Debian) there will be no window decorations due to a lack of CSD (client side decorations) support in Electron. This is being worked on upstream. KDE Wayland and wlroots should not have that issue as they have SSD (server side decorations) support.

Currently native Wayland support is not enabled by default in Electron 12, you'd have to pass --enable-features=UseOzonePlatform --ozone-platform=wayland at runtime.

@JaspalSuri
Copy link

Hi @vchernin, thank you for all of those details! I'll be sure to pass this along to the dev team.

@travislankow
Copy link

Adding that this is soon / now affecting larger numbers of users, now that Ubuntu 21.10 (releases Oct) and Debian 11 (released) and their derivatives are Wayland by default.

@JaspalSuri
Copy link

Thanks for the reminder! I'll bring this up with the team again.

@jacob-emery
Copy link

What version of Electron is SN built on?

--enable-features=UseOzonePlatform --ozone-platform=wayland does not work with the Flatpak. I would suggest upgrading to Electron 14 or 15.

@JaspalSuri
Copy link

I'll get in touch with the dev team and let you know!

@JaspalSuri
Copy link

Hello again @jacob-emery, sorry for the delayed response. The desktop app is built with version 9.4 of Electron. We plan to upgrade it to a newer version, though.

@jacob-emery
Copy link

@JaspalSuri thank you for the answer! Yeah, that is great news for us Linux enthusiasts :)

@JaspalSuri
Copy link

You're very welcome! Hopefully we'll be able to use more recent versions without it breaking too many things.

@proletarius101
Copy link
Author

Another upstream bug to be fixed: electron/electron#33355

@proletarius101
Copy link
Author

Upstream fix released. @JaspalSuri can you help with updating electron to 17.3.1 (similar to signalapp/Signal-Desktop#5847)?

@JaspalSuri
Copy link

JaspalSuri commented Apr 3, 2022

Hi @proletarius101, I’m currently not part of the SN team. CC @moughxyz

Thanks for the notification!

@proletarius101
Copy link
Author

Wayland support added in the Flatpak version: flathub/org.standardnotes.standardnotes#89

@ghost
Copy link

ghost commented Jun 5, 2022

@proletarius101
You should be aware that CJK folks still have an upstream blocking bug. They cannot enter their language in Wayland Electron apps and there is probably no known workaround at this time. (electron/electron#33662)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants