Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kali Linux #350

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

Cube707
Copy link
Contributor

@Cube707 Cube707 commented Jun 26, 2023

I added support for Kali Linux. The example now produces:

OS information: Kali Linux 2023.2.0 [64-bit]
Type: Kali Linux
Version: 2023.2.0
Edition: None
Codename: None
Bitness: 64-bit
Architecture: Some("x86_64")

I hope the test are enugh like this. I am not sure if I didn't see more relevant testcases

@Cube707
Copy link
Contributor Author

Cube707 commented Jun 27, 2023

I now also added support for when the lsb_release command is available. With the package installed the output is:

OS information: Kali Linux 2023.2 (kali-rolling) [64-bit]
Type: Kali Linux
Version: 2023.2
Edition: None
Codename: Some("kali-rolling")
Bitness: 64-bit
Architecture: Some("x86_64")

@Cube707
Copy link
Contributor Author

Cube707 commented Jun 27, 2023

and the tests all Pass on my machine.

But I get a warning related to missing_doc_code_examples which doesn't seem related to my changes so I didn't touch it.

@Cube707
Copy link
Contributor Author

Cube707 commented Jun 27, 2023

also, should I squash the two commit into one or keep them separate?

@stanislav-tkach
Copy link
Owner

stanislav-tkach commented Jul 21, 2023

Sorry for the super late response and thank you for the pull request! Please ignore warnings and errors on Windows, I will fix them in the next release that I also hope to publish soon. Also don't worry about the commits. 🙃

@stanislav-tkach stanislav-tkach merged commit 128967d into stanislav-tkach:master Jul 21, 2023
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants