-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme/skin support #189
Comments
Hi, very glad to have your suggestion. This is really a good idea for a custom graph theme. As you can see, the star-history website is being built with a sketchy feel. I still want to keep this anyway. But I think we can provide a theme parameter to the star-history SVG api. If you're interested in this, I'd be happy to get your PR. 🤓 |
Hi @SethFalco, @boojack , I have written a initial version of set the chart theme: commit, it works fine locally. But I have a little question here:
|
Just want to note while I can see how it may've come across that way, the color scheme was not the intent of this issue. Looks nice though, but it was more about look and feel of the graph. |
@gooin Nice try! But if you just change the theme of the chart, the website will look a little weird. And we'd like to still stay with the sketchy feeling of the website. So you can keep it for your own star-history. |
Is there any interest or room to add theming support to the generated graphs?
I haven't checked the code yet as I've recently learned about project. This is used in a few orgs I'm a member of, but some maintained have mentioned it'd be nice to have a more Professional™ looking graph.
Just wanted to explore if that would be feasible by appending a query parameter. I may look into this myself later, just wanted to leave a note and give maintainers room to shut me down if you have no interest in this.
The text was updated successfully, but these errors were encountered: