Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme/skin support #189

Open
SethFalco opened this issue Aug 9, 2022 · 5 comments
Open

Theme/skin support #189

SethFalco opened this issue Aug 9, 2022 · 5 comments

Comments

@SethFalco
Copy link

Is there any interest or room to add theming support to the generated graphs?

I haven't checked the code yet as I've recently learned about project. This is used in a few orgs I'm a member of, but some maintained have mentioned it'd be nice to have a more Professional™ looking graph.

Just wanted to explore if that would be feasible by appending a query parameter. I may look into this myself later, just wanted to leave a note and give maintainers room to shut me down if you have no interest in this.

@boojack
Copy link
Contributor

boojack commented Aug 14, 2022

Hi, very glad to have your suggestion. This is really a good idea for a custom graph theme.

As you can see, the star-history website is being built with a sketchy feel. I still want to keep this anyway. But I think we can provide a theme parameter to the star-history SVG api.

If you're interested in this, I'd be happy to get your PR. 🤓

gooin referenced this issue in gooin/star-history Aug 24, 2022
@gooin
Copy link

gooin commented Aug 24, 2022

Hi @SethFalco, @boojack , I have written a initial version of set the chart theme: commit, it works fine locally.

But I have a little question here:

  • If user changed the chartMode, the url hash will be changed synchronously, display as &TimeLine or &Date. In this theme work, I want to add themeMode to the url hash too, but I can't find where the function add the url hash. Can you help me? @boojack

@gooin
Copy link

gooin commented Aug 24, 2022

image
image
image

@SethFalco
Copy link
Author

Just want to note while I can see how it may've come across that way, the color scheme was not the intent of this issue.

Looks nice though, but it was more about look and feel of the graph.

@boojack
Copy link
Contributor

boojack commented Aug 25, 2022

@gooin Nice try! But if you just change the theme of the chart, the website will look a little weird. And we'd like to still stay with the sketchy feeling of the website. So you can keep it for your own star-history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@gooin @SethFalco @boojack and others