We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While running in a systemd-nspawn, the container module report OCI
container
OCI
systemd-nspawn or nspawn to be reported
systemd-nspawn
nspawn
When /run/host/container-manager exist, OCI is hardcoded
/run/host/container-manager
starship/src/modules/container.rs
Lines 24 to 27 in cce9d33
/run/systemd/container
Check the file content.
The text was updated successfully, but these errors were encountered:
hey @andytom can I work on this?
Sorry, something went wrong.
Yep sure please feel free to pick this up.
@andytom Hey, I fixed the issue, but can you have a look at the approach brewedBorrows/starship-fork1@master...brewedBorrows:starship-fork1:nspawn_OCI_#5937 . If you approve I will raise PR and add tests if needed.
Hey @brewedBorrows, the approach looks fine there are some things I would like to suggest but if you open a PR we can discuss them there.
#5943 Here's the PR @andytom
No branches or pull requests
Bug Report
Current Behavior
While running in a systemd-nspawn, the
container
module reportOCI
Expected Behavior
systemd-nspawn
ornspawn
to be reportedAdditional context/Screenshots
When
/run/host/container-manager
exist,OCI
is hardcodedstarship/src/modules/container.rs
Lines 24 to 27 in cce9d33
But systemd-nspawn also create this file with
systemd-nspawn
inside https://github.com/systemd/systemd/blob/8f0de5c433929782f7582a743d3b3d88bea9696d/src/nspawn/nspawn.c#L4148-L4149This check is made early, bypassing the
/run/systemd/container
one.Possible Solution
Check the file content.
The text was updated successfully, but these errors were encountered: