[5.x] Prevent certain blueprint config keys getting stripped out #10059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing on the "text" fieldtype
before the other PR, the logic was to remove "duplicate" if it was true. this is now saying to always remove it, which is incorrect. partly solves #10040
a force_in_config option will allow configs to avoid getting stripped out. it only applies to fields when used as configs.
it was only being added on the edit route, but should have also been there for the update route. the reason it didnt show an issue was because all falsey/null values were being stripped out anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9685 we stripped out redundant blueprint configs where they matched the defaults.
This looks to be a bit heavy handed in some situations.
This PR allows certain keys to be forced into the config even when they match the defaults.
truecan't be set tofalse#10040Replaces #10054