Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect flag results in migration error. "illegal offset type" #83

Open
alexmilde opened this issue Apr 12, 2021 · 3 comments
Open

protect flag results in migration error. "illegal offset type" #83

alexmilde opened this issue Apr 12, 2021 · 3 comments
Labels
feature request New feature or request

Comments

@alexmilde
Copy link

thanks for this amazing migrator. it helped a lot!

i ran into a bug which was hard to track down for me - maybe you can look into it.

v2 page.md:

protect:
  type: logged_in
  login_url: ../login

will result into an error exception (screenshot attached)
Bildschirmfoto 2021-04-12 um 15 02 33

solution

v3 page.md:

protect: logged_in

thanks again
Alex

@jasonvarga
Copy link
Member

In the future, make sure to include the error itself, which is just above where you've cropped the screenshot.

@alexmilde
Copy link
Author

if you want i can create a PR with the fix.

@jesseleite
Copy link
Member

Great FR for the migrator. Would need to handle custom protection schemes, or at least warn the user to update their protection schemes config.

@jesseleite jesseleite added the feature request New feature or request label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants