Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java10] removal of SecurityManager.getInCheck() #65

Open
dfa1 opened this issue Jul 3, 2018 · 2 comments
Open

[java10] removal of SecurityManager.getInCheck() #65

dfa1 opened this issue Jul 3, 2018 · 2 comments

Comments

@dfa1
Copy link

dfa1 commented Jul 3, 2018

I tried to compile this project with JDK10 and maven 3.5.0:

[ERROR] /Users/dfa/projects/system-rules/src/main/java/org/junit/contrib/java/lang/system/internal/NoExitSecurityManager.java:[39,9] method does not override or implement a method from a supertype
[ERROR] /Users/dfa/projects/system-rules/src/main/java/org/junit/contrib/java/lang/system/internal/NoExitSecurityManager.java:[42,51] cannot find symbol
[ERROR]   symbol:   method getInCheck()
[ERROR]   location: variable originalSecurityManager of type java.lang.SecurityManager

Looks like this method has been removed between java9 and java10: https://bugs.openjdk.java.net/browse/JDK-8189750

@dfa1 dfa1 changed the title [java10] [java10] removal of SecurityManager.getInCheck() Jul 3, 2018
@dfa1
Copy link
Author

dfa1 commented Jul 3, 2018

This fix could be to just remove the usage of getInCheck().

@stefanbirkner
Copy link
Owner

Thanks for reporting the problem.

That's "only" a compilation problem. It will not be fixed because System Rules can be used with JDK 10 but not be build by JDK 10. I extend the README respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants